Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore input file location characters in IBooker::bookME ME path check #38905

Merged
merged 1 commit into from Aug 1, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 30, 2022

PR description:

This PR partially solves the issue #38885, by letting the IBooker::bookME ME path checking code to ignore any sub-string containing a file name prior to the actual Monitor Element path in the ROOT file, as the leading characters are not useful to determine whether the MonitorElement path will have troubles indexing in the CMS Offline DQM GUI.

PR validation:

In this branch, added the package DQM/SiStripMonitorClient and run succesffuly the unit test:

scram b runtests_testSiStripDQM_OfflineTkMap

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

urgent

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38905/31344

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

test parameters:

  • addpkg = DQM/SiStripMonitorClient

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4a340/26545/summary.html
COMMIT: 4201f01
CMSSW: CMSSW_12_5_X_2022-07-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38905/26545/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3668050
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3668026
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor

Is this fix for #38885 ready to be merged?

@qliphy
Copy link
Contributor

qliphy commented Aug 1, 2022

@cms-sw/dqm-l2 Do you have any comment on this PR?

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 1, 2022

+1

@cmsbuild cmsbuild merged commit 1838b4b into cms-sw:master Aug 1, 2022
@forthommel forthommel mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants