New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore input file location characters in IBooker::bookME
ME path check
#38905
Conversation
type bug-fix |
urgent |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38905/31344
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4a340/26545/summary.html Comparison SummarySummary:
|
Is this fix for #38885 ready to be merged? |
@cms-sw/dqm-l2 Do you have any comment on this PR? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR partially solves the issue #38885, by letting the
IBooker::bookME
ME path checking code to ignore any sub-string containing a file name prior to the actual Monitor Element path in the ROOT file, as the leading characters are not useful to determine whether theMonitorElement
path will have troubles indexing in the CMS Offline DQM GUI.PR validation:
In this branch, added the package
DQM/SiStripMonitorClient
and run succesffuly the unit test:scram b runtests_testSiStripDQM_OfflineTkMap
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A