Various fixes for pixel clustering on GPU

[fwyzard]

PR description:

Various fixes for pixel clustering on GPU:

• when building in debug mode (g++ -DGPU_DEBUG) synchronise only the current stream instead of the whole device after each operation;
• size the kernel grid based on the correct number of pixel modules for Phase-1;
• remove obsolete debug statement that does not compile any more.

PR validation:

None.

If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW 12.4.x for data taking at HLT.

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

@AdrianoDee FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38920/31368

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359, Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761, Automatically size the Pixel FED buffer used by SiPixelRawToClusterCUDA #38868
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorKernelsImpl.h modified in PR(s): Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761, Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)

@jpata, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-042140/26572/summary.html
COMMIT: 0c718bd
CMSSW: CMSSW_12_5_X_2022-08-01-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38920/26572/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19868
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 1 / 3 workflows

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3669004
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3668980
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• bugfixes and cleanup
• no differences in reco tests
• as far as I understand, if there are any differences, it should be in HLT and a bugfix (i.e. fixing something that was not correct)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[fwyzard]

urgent

I would like to have the backport in 12.4.x in order to simplify further debugging

[qliphy]

+1