Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit the number of seeds, same as in CkfTrackCandidateMakerBase (backport of #38926) #38927

Merged
merged 1 commit into from Aug 3, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion RecoTracker/MkFit/plugins/MkFitSeedConverter.cc
Expand Up @@ -60,6 +60,7 @@ class MkFitSeedConverter : public edm::global::EDProducer<> {
const edm::ESGetToken<MkFitGeometry, TrackerRecoGeometryRecord> mkFitGeomToken_;
const edm::ESGetToken<MagneticField, IdealMagneticFieldRecord> mfToken_;
const edm::EDPutTokenT<MkFitSeedWrapper> putToken_;
const unsigned int maxNSeeds_;
};

MkFitSeedConverter::MkFitSeedConverter(edm::ParameterSet const& iConfig)
Expand All @@ -69,13 +70,15 @@ MkFitSeedConverter::MkFitSeedConverter(edm::ParameterSet const& iConfig)
ttopoToken_{esConsumes<TrackerTopology, TrackerTopologyRcd>()},
mkFitGeomToken_{esConsumes<MkFitGeometry, TrackerRecoGeometryRecord>()},
mfToken_{esConsumes<MagneticField, IdealMagneticFieldRecord>()},
putToken_{produces<MkFitSeedWrapper>()} {}
putToken_{produces<MkFitSeedWrapper>()},
maxNSeeds_{iConfig.getParameter<unsigned int>("maxNSeeds")} {}

void MkFitSeedConverter::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
edm::ParameterSetDescription desc;

desc.add("seeds", edm::InputTag{"initialStepSeeds"});
desc.add("ttrhBuilder", edm::ESInputTag{"", "WithTrackAngle"});
desc.add("maxNSeeds", 500000U);

descriptions.addWithDefaultLabel(desc);
}
Expand All @@ -95,6 +98,11 @@ mkfit::TrackVec MkFitSeedConverter::convertSeeds(const edm::View<TrajectorySeed>
const MagneticField& mf,
const MkFitGeometry& mkFitGeom) const {
mkfit::TrackVec ret;
if (seeds.size() > maxNSeeds_) {
edm::LogError("TooManySeeds") << "Exceeded maximum number of seeds! maxNSeeds=" << maxNSeeds_
<< " nSeed=" << seeds.size();
return ret;
}
ret.reserve(seeds.size());

auto isPlusSide = [&ttopo](const DetId& detid) {
Expand Down