Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the autoSkim.py for new HLT menu v1.3 #38933

Merged
merged 5 commits into from Aug 7, 2022
Merged

Conversation

sam7k9621
Copy link
Contributor

PR description:

To be synced with PD changes in the new HLT menu (v1.3)

Merged SingleMuon and DoubleMuon into Muon dataset
Merged JetHT and MET into JetMET dataset
Removed unused PD ParkingBPH

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

#38909 backport to CMSSW_12_4_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38933/31378

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

A new Pull Request was created by @sam7k9621 for master.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@kskovpen
Copy link
Contributor

kskovpen commented Aug 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2022

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3733a7/26611/summary.html
COMMIT: bcc7fa0
CMSSW: CMSSW_12_5_X_2022-08-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38933/26611/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

RelVals-INPUT

'DisplacedJet' : 'EXODisplacedJet+EXODelayedJet+EXODTCluster+EXOCSCCluster+LogError+LogErrorMonitor',
'MET' : 'EXOHighMET+EXODelayedJetMET+LogError+LogErrorMonitor',
'JETMET' : 'JetHTJetPlusHOFilter+EXOHighMET+EXODelayedJetMET+LogError+LogErrorMonitor',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the dataset is JetMET (not JETMET). Does this matter here, or is this case-insensitive?

Copy link
Contributor Author

@sam7k9621 sam7k9621 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@missirol @kskovpen thanks for the reminder, it is fixed now.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38933/31402

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

Pull request #38933 was updated. @cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please check and sign again.

@kskovpen
Copy link
Contributor

kskovpen commented Aug 3, 2022

please test

@sam7k9621
Copy link
Contributor Author

@srimanob thank you for your advice, I have already added the condition on the scenario part and added the "SingleMuon" to the autoSkim.py

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38933/31426

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2022

Pull request #38933 was updated. @perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@kskovpen
Copy link
Contributor

kskovpen commented Aug 5, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3733a7/26648/summary.html
COMMIT: 28675f5
CMSSW: CMSSW_12_5_X_2022-08-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38933/26648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691510
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3691480
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

kskovpen commented Aug 5, 2022

+pdmv

@srimanob
Copy link
Contributor

srimanob commented Aug 5, 2022

+Upgrade

@qliphy
Copy link
Contributor

qliphy commented Aug 7, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit bbffe91 into cms-sw:master Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants