Remove duplicate pixels [12.4.x]

[fwyzard]

PR description:

Backport of #37559 by @ferencek .

This PR completely removes all duplicate pixels from the clustering step. This is an alternative to #37496 where charges from duplicate pixels are summed up.

No changes are expected in MC samples. In the data there could be some tiny differences in case some duplicate pixels appear.

PR validation:

Code compiles :)

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #37559 for data taking.

[fwyzard]

type bugfix

[fwyzard]

backport #37559

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

• DataFormats/SiPixelCluster (reconstruction)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Remove duplicate pixels #37559

[fwyzard]

please test

[fwyzard]

urgent

[fwyzard]

Non-urgently needed for data taking for compatibility with #38947

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f90d95/26608/summary.html
COMMIT: 16ef008
CMSSW: CMSSW_12_4_X_2022-08-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38950/26608/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6523 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 52177
• DQMHistoTests: Total nulls: 15
• DQMHistoTests: Total successes: 3623984
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[qliphy]

Should comments brought in the master PR be also included here?
#37559 (comment)

[fwyzard]

I think we can simply avoid considering and merging this until we converge on #37559 .

[fwyzard]

hold

[cmsbuild]

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[cmsbuild]

Pull request #38950 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f90d95/26707/summary.html
COMMIT: 299d266
CMSSW: CMSSW_12_4_X_2022-08-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38950/26707/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6525 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 52181
• DQMHistoTests: Total nulls: 15
• DQMHistoTests: Total successes: 3625024
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• a direct backport of Remove duplicate pixels #37559, required for datataking (see inline for the discussion)

[jpata]

@fwyzard is it still on hold from your side? if not, would you mind doing "unhold"? I'm not sure if I should/could do it myself.

[fwyzard]

Apologies - no, this should be fine now.

[fwyzard]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1