Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a random seed for random number generator explicitly for HGCAL MC of Muon Tomography #38957

Merged
merged 1 commit into from Aug 6, 2022

Conversation

indra-ehep
Copy link
Contributor

@indra-ehep indra-ehep commented Aug 3, 2022

PR description:

Added random number seed generated by another random number. This is to avoid the identical sequence of MC events while generating for large sample via HTCondor or similar grid utilities.

PR validation:

Few standalone tests with cmsRun results desired output showing different seeds in various runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not applicable

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38957/31403

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

A new Pull Request was created by @indra-ehep for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@indra-ehep indra-ehep changed the title Adding a random seed for random number generator for MC generation Adding a random seed for random number generator of MC generation Aug 3, 2022
@bsunanda
Copy link
Contributor

bsunanda commented Aug 4, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8afef/26638/summary.html
COMMIT: 629b87b
CMSSW: CMSSW_12_5_X_2022-08-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38957/26638/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691510
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3691486
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy qliphy changed the title Adding a random seed for random number generator of MC generation Adding a random seed for random number generator of HGCAL MC generation Aug 6, 2022
@qliphy
Copy link
Contributor

qliphy commented Aug 6, 2022

+1
change the title to mention explicitly this is for HGCAL MC

@cmsbuild cmsbuild merged commit 2373b50 into cms-sw:master Aug 6, 2022
@indra-ehep indra-ehep changed the title Adding a random seed for random number generator of HGCAL MC generation Adding a random seed for random number generator "explicitly" for HGCAL MC of Muon Tomography Aug 7, 2022
@indra-ehep indra-ehep changed the title Adding a random seed for random number generator "explicitly" for HGCAL MC of Muon Tomography Adding a random seed for random number generator explicitly for HGCAL MC of Muon Tomography Aug 7, 2022
@indra-ehep
Copy link
Contributor Author

+1 change the title to mention explicitly this is for HGCAL MC

The title has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants