Revert MuonDetLayerGeometry using modules to stream modules #3896
Conversation
The static analyzer was complaining that sortSegRadius was non-const. Changed this to const and put it in an anonymous namespace.
The MuonDetLayerGeometry class was made const thread safe so it is safe to make the modules which use it stream modules. In addition, performance tests of the threaded framework were showing some of these modules were causing bottlenecks when they were legacy modules.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Revert MuonDetLayerGeometry using modules to stream modules It involves the following packages: RecoMuon/CosmicMuonProducer @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
|
-1 class lumi::HLTInfo class std::vectorlumi::HLTInfo class lumi::BunchCrossingInfo class std::vectorlumi::BunchCrossingInfo class lumi::LumiSectionData gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2 you can see the results of the tests here: |
|
Sorry I accidentally used 7_0_X. I will start the tests again. |
SETMuonSeedProducer had to be downgraded to a legacy module since it uses the thread-unsafe CLHEP matricies in SETFilter::findParabolaMinimum.
|
The CLHEP matrix problem was found by helgrind. It was the only issue found related to this pull request. |
|
-1 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log you can see the results of the tests here: |
|
@slava77 @anton-a @davidlange6 Ping? These are definitely needed for thread performance and I think should be considered bug fixes. |
|
couldn't sign until there's a working IB and jenkins runs |
|
+1 for #3896 10e7c4a |
…ngModulesToStream Multithreading -- Revert MuonDetLayerGeometry using modules to stream modules
The MuonDetLayerGeometry class was made const thread-safe so it is safe to make the modules which use it stream modules. In addition, performance tests of the threaded framework were showing some of these modules were causing bottlenecks when they were legacy modules.