Handle pixel modules with all invalid pixels

[fwyzard]

PR description:

Deal with the the case where all pixels in a module are invalid or duplicate.

PR validation:

Testes over data from run 356998: the events which caused crashes with CMSSW_12_4_5_patch1 are being processed without errors with these changes.

If this PR will be backported please specify to which release cycle the backport is meant for:

Backported to CMSSW 12.4.x for data taking: #38989 .

[fwyzard]

type bugfix

[fwyzard]

urgent

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

@VinInn @AdrianoDee FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38988/31447

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359, Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jpata, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

please test

[fwyzard]

I've updated the PR to take into account the case where the invalid or duplicate pixels extend to the end of the last module.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38988/31452

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359, Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

[cmsbuild]

Pull request #38988 was updated. @jpata, @clacaputo can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e81a5b/26697/summary.html
COMMIT: 7ca6d96
CMSSW: CMSSW_12_5_X_2022-08-07-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38988/26697/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19868
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 2 / 3 workflows

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3691612
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3691582
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• bugfix for GPU (validated by the author)
• no reco changes in standard tests

[jpata]

@cms-sw/trk-dpg-l2 do we need a corresponding update in the CPU code for consistency?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

do we need a corresponding update in the CPU code for consistency?

I think after #37559 is going to be merged, there should not be other updates needed. If all the pixel are duplicates in the CPU clusterizer nothing happens. @ferencek please confirm.

[qliphy]

+1

[fwyzard]

Longer term, would it be useful to monitor the amount of duplicate pixels and fully invalid modules ?

[mmusich]

Longer term, would it be useful to monitor the amount of duplicate pixels and fully invalid modules ?

when I left it was in the plans. Not sure what are the current ones @sroychow

[ferencek]

do we need a corresponding update in the CPU code for consistency?

I think after #37559 is going to be merged, there should not be other updates needed. If all the pixel are duplicates in the CPU clusterizer nothing happens. @ferencek please confirm.

Correct, if all pixels in a given module turn out to be duplicates, there is nothing to cluster and the module is effectively skipped (I say effectively because there is still a loop over clustering seeds done but the vector of seeds is empty).