Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add class version SiStripApproximateCluster #38992

Merged
merged 1 commit into from Aug 9, 2022
Merged

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Aug 8, 2022

As pointed out by @makortel #38870 (comment), we forgot to keep the old class version in #38870.

As pointed out by @makortel cms-sw#38870 (comment), we forgot to keep the old class version in cms-sw#38870.
@jpata
Copy link
Contributor Author

jpata commented Aug 8, 2022

test parameters:

  • workflow = 140.58

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38992/31456

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

  • DataFormats/SiStripCluster (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@echabert, @swertz, @robervalwalsh, @rovere, @VinInn, @alesaggio, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor Author

jpata commented Aug 8, 2022

@cmsbuild please test

@jpata jpata changed the title Readd class version SiStripApproximateCluster Re-add class version SiStripApproximateCluster Aug 8, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77c0f3/26701/summary.html
COMMIT: 6a99e95
CMSSW: CMSSW_12_5_X_2022-08-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38992/26701/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-77c0f3/140.58_RunHI2018+RunHI2018+RAWPRIMEHI18+RECOHID18APPROXCLUSTERS+HARVESTDHI18

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3753054
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3753030
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 216 log files, 49 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor Author

jpata commented Aug 9, 2022

attn. @abaty

@jpata
Copy link
Contributor Author

jpata commented Aug 9, 2022

+reconstruction

  • bugfix for backwards compatibility
  • no reco changes

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 9, 2022

+1

@cmsbuild cmsbuild merged commit 3f0a962 into cms-sw:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants