Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal slhc14 sim detidfix #3901

Merged
merged 4 commits into from May 19, 2014

Conversation

pfs
Copy link
Contributor

@pfs pfs commented May 16, 2014

Fixes issue found with DetId for SimHits due to large number of layers in EE and HEfront.
Added translation from SimHit DetId to HGC DetId at digitization level.
Adding MIP/5 like thresholds to the trivial digitizer and removed noise.
@vandreev11 @bsunanda @amagnan - check it as well, please.

pfs added 4 commits May 16, 2014 14:08
…ents

Solved by applying z layer ganging on the fly to the SimHits in HGCSD
Adding gain bit to HGCSample and giving 15 bit to ADC
Adding more functions to set/get specific bitsets in an sample
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

Hgcal slhc14 sim detidfix

It involves the following packages:

DataFormats/ForwardDetId
DataFormats/HGCDigi
SimCalorimetry/HGCSimProducers
SimG4CMS/Calo
SimGeneral/MixingModule

The following packages do not have a category, yet:

DataFormats/ForwardDetId
DataFormats/HGCDigi
SimCalorimetry/HGCSimProducers

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

merge

passing tests: 10000,10200,10400,11200,11400,12000,12800,13000,13600,14600
failing tests: 12200 Step2-FAILED code 34304,12400 Step2-FAILED code 34304,12600 Step1-FAILED code 34304,13800 Step2-FAILED code 34304,14000 Step2-FAILED code 34304,14200 Step2-FAILED code 34304,14400 Step2-FAILED code 34304

cmsbuild added a commit that referenced this pull request May 19, 2014
@cmsbuild cmsbuild merged commit 51ac1d4 into cms-sw:CMSSW_6_2_X_SLHC May 19, 2014
@pfs pfs deleted the hgcal_slhc14_sim_detidfix branch November 18, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants