implement event consumes in MuScleFit
#39029
Conversation
|
type trk,bugfix |
|
urgent
|
|
assign alca
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39029/31516
|
|
New categories assigned: alca @yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| puInfoSrc_ = pset.getUntrackedParameter<edm::InputTag>("PileUpSummaryInfo"); | ||
| puInfoToken_ = consumes<std::vector<PileupSummaryInfo> >(puInfoSrc_); | ||
|
|
||
| vertexSrc_ = pset.getUntrackedParameter<edm::InputTag>("PrimaryVertexCollection"); | ||
| vertexToken_ = consumes<reco::VertexCollection>(vertexSrc_); | ||
|
|
||
| genEvtInfoToken_ = consumes<GenEventInfoProduct>(edm::InputTag("generator")); |
There was a problem hiding this comment.
couldn't these go to the constructor?
There was a problem hiding this comment.
they are in the constructor.
There was a problem hiding this comment.
@mmusich sorry I meant the initializer list.
There was a problem hiding this comment.
@tvami, I think we can leave the const correctness of the tokens for later, what do you think? feel free to open an issue about it (I am not the maintainer of this package by the way)
There was a problem hiding this comment.
ok, let's do it in a follow-up PR then!
| edm::EDGetTokenT<edm::TriggerResults> triggerResultsToken_; | ||
| edm::EDGetTokenT<reco::VertexCollection> vertexToken_; | ||
| edm::EDGetTokenT<std::vector<PileupSummaryInfo> > puInfoToken_; | ||
| edm::EDGetTokenT<GenEventInfoProduct> genEvtInfoToken_; |
There was a problem hiding this comment.
and then these could be const
There was a problem hiding this comment.
no, because they are not in the initializer list.
MuonAnalysis/MomentumScaleCalibration/plugins/MuScleFitMuonSelector.h
Outdated
Show resolved
Hide resolved
|
unassign analysis
|
|
@cmsbuild , please test
|
right I was planning to add a unit test for the alignment usage, but only once you sign #38723 because I can profit of the re-organization of the unit tests done there. |
|
in the wishlist for the follow-up PR, we should also have a unit test with the config in |
|
We wrote at the same time. In the meantime, I signed the #38723 too |
mmusich
force-pushed
the
muscleFitConsumes
branch
from
6ce1ed5
to
3d20241
Compare
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-started
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39029/31519
|
|
Pull request #39029 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aebfda/26758/summary.html Comparison SummarySummary:
|
|
+alca
|
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
resolves #38958
PR description:
Title says it all.
PR validation:
Run with this branch the configuration posted at #38958 (comment) (for convenience also available here) successfully.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will need to be backported to CMSSW_12_4_X for tracker alignment validation purposes.