New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend CMS protections in Geant4 exception handling #39032
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39032/31518
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df40d4/26759/summary.html Comparison SummarySummary:
|
+1 this is a technical PR, which help to reduce problems in production and cannot affect results |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In MinBias production for Run3 a visible % of jobs crash due to Geant4 problem of tracking of low energy (~5 keV) electrons. It is clear that the problem is numerical - for small steps of electrons of low energy numerical precsion is lost in Geant4 computations. This PR provide work around this rare problem. No change in SIM hits for low statistic run is expected.
PR validation:
Locally the problem was not yet reproduced but this approach was validated previously in similar circonstances with more frequent problems.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will be backported to 12_4