Update MPI tools and tests #39036
Update MPI tools and tests #39036
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39036/31522
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
fwyzard
changed the title
cmsenv_mpirun to work with $CMSSW_RELEASE_BASE
|
please test |
|
+heterogeneous |
cmsbuild
added
fully-signed
heterogeneous-approved
tests-started
and removed
pending-signatures
tests-pending
heterogeneous-pending
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39036/31523
|
|
Pull request #39036 was updated. can you please check and sign again. |
| RELEASE_BASE=$CMSSW_BASE | ||
| elif [ -x $CMSSW_RELEASE_BASE/bin/$SCRAM_ARCH/cmsenv_orted ]; then | ||
| RELEASE_BASE=$CMSSW_RELEASE_BASE | ||
| else |
There was a problem hiding this comment.
I believe it could make sense to check also $CMSSW_FULL_RELEASE_BASE for the case that $CMSSW_RELEASE_BASE is a patch release. (alternative could be to find the location of cmsenv_orted from $PATH, but I'm not sure if that could have some undesired effect)
There was a problem hiding this comment.
Good point, thanks.
Update "cmsenv_mpirun" to look for "cmsenv_orted" under - $CMSSW_BASE - $CMSSW_RELEASE_BASE - $CMSSW_FULL_RELEASE_BASE In verbose mode, print the command before executing it.
fwyzard
force-pushed
the
update_cmsenv_mpirun_125x
branch
from
ec2aa37
to
76de570
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39036/31525
|
|
please test |
|
+heterogeneous |
cmsbuild
added
fully-signed
heterogeneous-approved
and removed
pending-signatures
heterogeneous-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ee12b/26770/summary.html Comparison SummarySummary:
|
|
+1 |
PR description:
Update
cmsenv_mpirunto look forcmsenv_ortedalso under the base releases.Move the test for CUDA availability from
mpiCudaGenericbinary to the BuildFile.xml.PR validation:
Tested using a CMSSW area with
cmsenv_ortedunder$CMSSW_RELEASE_BASE/bin/and not under$CMSSW_BASE/bin.If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to CMSSW 12.4.x for ongoing DAQ tests (not used for data taking): see #39037.