Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that I have misunderstood what actually "rebasing" meant.
After having performed those commands i saw that my changes were included in the CMSSW version I had (while i expected actually to have to redo my changes).
Using git status, git diff etc inside my rebased CMSSW version I could not spot any difference with the release, so I thought it was ok. but seems it was not.
I have checked out a new build and have made a new pull request to include the rotations.