Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc rotations #3904

Merged
merged 3 commits into from May 16, 2014
Merged

Conversation

pietverwilligen
Copy link
Contributor

Seems that I have misunderstood what actually "rebasing" meant.
After having performed those commands i saw that my changes were included in the CMSSW version I had (while i expected actually to have to redo my changes).

Using git status, git diff etc inside my rebased CMSSW version I could not spot any difference with the release, so I thought it was ok. but seems it was not.

I have checked out a new build and have made a new pull request to include the rotations.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pietverwilligen for CMSSW_6_2_X_SLHC.

Rpc rotations

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@andersonjacob
Copy link
Contributor

merge

passing tests:
10000
10200
10400
11200
11400
12000
12800
13000
13600
14600

tests which are known to fail
12200 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
12400 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
12600 Step0-PASSED 0 Step1-FAILED 34304 Step2-NOTRUN 0 Step3-NOTRUN 0
13800 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14000 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14200 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14400 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0

cmsbuild added a commit that referenced this pull request May 16, 2014
@cmsbuild cmsbuild merged commit a415ae6 into cms-sw:CMSSW_6_2_X_SLHC May 16, 2014
@pietverwilligen pietverwilligen deleted the RPCRotations branch October 21, 2014 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants