Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamer input source prefetching (12_5_X) #39088

Merged
merged 12 commits into from Aug 22, 2022
Merged

Streamer input source prefetching (12_5_X) #39088

merged 12 commits into from Aug 22, 2022

Commits on Aug 16, 2022

  1. prefetch configurable buffer size per posix read in the Streamer inpu… 

    …t source
    @smorovic
    smorovic committed Aug 16, 2022
    Copy the full SHA
    7d3b877 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. use original buffer when possible

    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    852316c View commit details
    Browse the repository at this point in the history

  2. code-format

    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    67c9d9e View commit details
    Browse the repository at this point in the history

  3. add unit test file

    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    99709c7 View commit details
    Browse the repository at this point in the history

  4. Update IOPool/Streamer/src/StreamerInputFile.cc 

    Using the actual buffer size

Co-authored-by: Chris Jones <chrisdjones15@gmail.com>
    @smorovic @Dr15Jones
    smorovic and Dr15Jones committed Aug 17, 2022
    Copy the full SHA
    7e8bf5f View commit details
    Browse the repository at this point in the history

  5. * fix unsafe usage of a pointer after potential resize of the vector, 

    which can relocate the buffer in heap

* expand unit test and process twice the file larger than the prefetch
 buffer (to check if there is any problem with zero-copy handling of the
 header)
    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    cdb7bb3 View commit details
    Browse the repository at this point in the history

  6. *readBytes returning data buffer pointer 

    *disable zero-copy for event buffer as it is not aligned address
* enclose header access before buffer vector is resized
    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    5e3598f View commit details
    Browse the repository at this point in the history

  7. Update IOPool/Streamer/test/RunSimple_NewStreamer.sh 

    Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch>
    @smorovic @makortel
    smorovic and makortel committed Aug 17, 2022
    Copy the full SHA
    b17a3b8 View commit details
    Browse the repository at this point in the history

  8. code format fix

    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    496378e View commit details
    Browse the repository at this point in the history

  9. fix code-checks

    @smorovic
    smorovic committed Aug 17, 2022
    Copy the full SHA
    3db4eed View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. * improve comments for the readBytes function 

    * remove unnecessary class member
* allow zero-copy event reading because EventHeader and EventMessage consist of byte and byte array variables and non-aligned casting is safe
    @smorovic
    smorovic committed Aug 19, 2022
    Copy the full SHA
    20d7222 View commit details
    Browse the repository at this point in the history

  2. apply code-checks

    @smorovic
    smorovic committed Aug 19, 2022
    Copy the full SHA
    d6ea8aa View commit details
    Browse the repository at this point in the history