[LTO] Fix ODR warnings for Validation/MtdValidation

[smuzaffar]

LTO build complains that struct MTDHit is defined multiple time in the package

• https://github.com/cms-sw/cmssw/blob/master/Validation/MtdValidation/plugins/BtlSimHitsValidation.cc#L42-L48
• https://github.com/cms-sw/cmssw/blob/master/Validation/MtdValidation/plugins/BtlLocalRecoValidation.cc#L45-L51

This PR proposes to change the name of one of these.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39136/31703

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[smuzaffar]

please test for CMSSW_12_5_LTO_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78c190/26980/summary.html
COMMIT: fe50e50
CMSSW: CMSSW_12_5_X_2022-08-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39136/26980/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693040
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692998
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78c190/26981/summary.html
COMMIT: fe50e50
CMSSW: CMSSW_12_5_LTO_X_2022-08-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39136/26981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1009 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693040
• DQMHistoTests: Total failures: 11103
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3681915
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/dqm-l2 can you please review this? Note that unit test failure is not related to this change.

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge

[fabiocos]

@smuzaffar thanks for catching and fixing it