fix for process-name check in TriggerSummaryProducerAOD

[missirol]

PR description:

The boolean used to initialise InputTagSets inside TriggerSummaryProducerAOD controls whether or not process names are ignored when comparing InputTags.

cmssw/HLTrigger/HLTcore/plugins/TriggerSummaryProducerAOD.cc

Lines 265 to 266 in 0c04ca4

	InputTagSet filterTagsEvent(pn_ != "*");
	InputTagSet collectionTagsEvent(pn_ != "*");

cmssw/HLTrigger/HLTcore/interface/TriggerSummaryProducerAOD.h

Line 116 in 0c04ca4

using InputTagSet = std::set<edm::InputTag, OrderInputTag>;

cmssw/HLTrigger/HLTcore/interface/TriggerSummaryProducerAOD.h

Line 99 in 0c04ca4

OrderInputTag(bool ignoreProcess) : ignoreProcess_(ignoreProcess){};

If the keyword "*" is used, the flag ignoreProcess should be true, not the other way around.

PR validation:

Manual tests, see #38442 (comment).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_12_4_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39141/31715

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/HLTcore/plugins/TriggerSummaryProducerAOD.cc modified in PR(s): [L1T] Phase-2, remove old simulation and adapt DQM #38442

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• HLTrigger/HLTcore (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa5de6/27001/summary.html
COMMIT: 9cac195
CMSSW: CMSSW_12_5_X_2022-08-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39141/27001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693040
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693004
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

type bugfix

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1