[12_4_X] Fix OOT plot in PPS Diamond DQM

[ChrisMisan]

PR description:

This PR aims to fix the incorrect filling of the OOT histogram in the PPS Diamond DQM. It is correcting two issues:

• by default no_TOT = -1 so it should be filtered out by condition TOT!=-1 or, as recommended by expert, TOT>0
• x coordinate has to take into account number of windows, the shift was hardcoded to 0.25 which is only correct for windowsNum=4

PR validation:

standard tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #39132

[ChrisMisan]

type ctpps, bug-fix

[ChrisMisan]

backport of #39132

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X.

It involves the following packages:

• DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix OOT plot in PPS Diamond DQM #39132

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-525321/27011/summary.html
COMMIT: 2a430fa
CMSSW: CMSSW_12_4_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39145/27011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3677206
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

testing at P5
I assume you need this deployed online?

[tvami]

@emanueleusai @ChrisMisan should this be included in the next 12_4_X?

[ChrisMisan]

@emanueleusai yes, it should be deployed online, many thanks!
@tvami if it's possible, but if I understood correctly, online deployment is separate from the CMSSW release.

[tvami]

online deployment is separate from the CMSSW release.

indeed it is, ok so this is not urgent, thanks!

[emanueleusai]

tests completed, deployed at P5

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1