fix for NOT operator in triggerExpression::Parser [12_4_X]
#39151
Conversation
- Improve the representation of trigger expression
- Improved the dumped representation of trigger expressions:
- AND, OR, and NOT operators add parentheses around their subexpression;
- uninitialised Path and L1uGT readers use an explicit name instead of FALSE.
- Print how the expressions are interpreted
- Delimit tokens and operands
- Require a delimiter after each token and operamd, to avoid en expression like:
"NOTSomePath ANDOtherPath"
to be parsed as:
"NOT SomePath AND OtherPath"
- Add more tests
- Compare the parsed and expected representations
|
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
type bugfix |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a85dca/27018/summary.html Comparison SummarySummary:
|
|
+hlt |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
backport of #39108
PR description:
From #39108 (comment):
NOToperator in the parser used byTriggerResultsFilterAND/OR/NOT, allowing for expressions likeNOT NOT)AND/OR/NOTas names of HLT paths; the implementation of that requirement is maybe suboptimal, but it passes all the tests and considered use casesTriggerResultsFilterimproved accordinglyThanks to @fwyzard for finding the solution, and improving the initial version of the PR.
See description and discussions in the original PR for more information.
PR validation:
Relies on the validation done for the original PR.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
#39108
Backport of a bugfix to the release cycle currently used for online operations.