Timing, Laser and Hot cell quality plots adjustments [12_4_X]

[abhih1]

PR description:

This PR does the following in ECAL DQM plots:

1. Changes the threshold in Timing quality summary to reduce the false positives in Ecal Endcaps
2. Changes the amplitude threshold in laser quality for the forward region of Ecal Endcaps
3. Disables the condition for setting entire FED to RED in Hot Cell quality as it's creating false alarms in the presence of single hot towers.

PR validation:

Validated by running the standard online Ecal DQM configuration and checking the output on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of master PR: #39161. Backport is done to have the changes available in 12_4_X which is currently used in production.

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_4_X.

It involves the following packages:

• DQM/EcalMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Timing, Laser and Hot cell quality plots adjustments [Master] #39161

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7b3f8/27037/summary.html
COMMIT: 64f83fa
CMSSW: CMSSW_12_4_X_2022-08-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39162/27037/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 53
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677167
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

testing at P5

[cmsbuild]

Pull request #39162 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[micsucmed]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7b3f8/27161/summary.html
COMMIT: 5a20823
CMSSW: CMSSW_12_4_X_2022-08-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39162/27161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677280
• DQMHistoTests: Total failures: 53
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677205
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

re-testing at P5 after update

[micsucmed]

Hi @abhih1, would you mind checking the DQM playback GUI for the changes made in this PR? Let me know if everything seems ok. Thanks!

[abhih1]

Looks good. Thanks!

…

On Tue, 30 Aug 2022, 14:07 Michel Succar Medina, ***@***.***> wrote: Hi @abhih1 <https://github.com/abhih1>, would you mind checking the DQM playback GUI for the changes made in this PR? Let me know if everything seems ok. Thanks! — Reply to this email directly, view it on GitHub <#39162 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHGCS4YLFFWRIMPPJQDBTJ3V3X2PRANCNFSM57NH64UA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[emanueleusai]

tests at P5 ok

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #39161

[perrotta]

This is a backport of master PR: #39161. Backport is done to have the changes available in 12_4_X which is currently used in production.

... and 12_5_X will be used in production next
Please provide also a 12_5_X backport of whatever you plan to backport to 12_4

[abhih1]

This is a backport of master PR: #39161. Backport is done to have the changes available in 12_4_X which is currently used in production.

... and 12_5_X will be used in production next Please provide also a 12_5_X backport of whatever you plan to backport to 12_4

Hi @perrotta Here is the backport to 12_5_X. #39327

[perrotta]

Thank you @abhih1 !

[perrotta]

+1