FastSim: ParticleDecays: fixed bugs to pythia8 option, made pythia8 opti...

[lveldere]

• compiles and runs
• detailed low stat validation with particle guns
• next: high stat validation with particle guns

[cmsbuild]

A new Pull Request was created by @lveldere for CMSSW_7_1_X.

FastSim: ParticleDecays: fixed bugs to pythia8 option, made pythia8 opti...

It involves the following packages:

FastSimulation/ParticleDecay
FastSimulation/TrajectoryManager

@cmsbuild, @Degano, @giamman, @lveldere, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lveldere]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[giamman]

Good job, Lukas. But so, the pythia8 option is now active by default? Did you validate that it does what it should, e.g. that all unstable particles decay and that no particle decays more than once?

[lveldere]

Hi Andrea

I validated things with a particle gun.
I shot taus into the detector with a plain particle gun
(no pythia particle gun, so no decays done before FastSim)
I checked the lifetimes and branching ratios of the taus,
and I checked the subsequent decays of pions.
I will do this in some more detail the next days,
also with particles other than taus.

Does that seem sufficient to you?

Lukas

On Mon, May 19, 2014 at 6:54 PM, Andrea Giammanco
notifications@github.comwrote:

Good job, Lukas. But so, the pythia8 option is now active by default? Did
you validate that it does what it should, e.g. that all unstable particles
decay and that no particle decays more than once?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3925#issuecomment-43528960
.

[giamman]

It sounds good, but just to be sure, can you also try with some more unstable particles, like B+?

[lveldere]

yes, this is the plan: K^0_L, B+, D+

On Tue, May 20, 2014 at 8:47 AM, Andrea Giammanco
notifications@github.comwrote:

It sounds good, but just to be sure, can you also try with some more
unstable particles, like B+?

---

Andrea Giammanco
Office phone: +32 10 478185
Mobiles: +32 493 581662 (BE), +41 76 2323672 (CH), +39 349 5552471 (IT), +972
546307196 (IL)

---

From: lveldere [notifications@github.com]
Sent: 20 May 2014 08:46
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] FastSim: ParticleDecays: fixed bugs to pythia8
option, made pythia8 opti... (#3925)

Hi Andrea

I validated things with a particle gun.
I shot taus into the detector with a plain particle gun
(no pythia particle gun, so no decays done before FastSim)
I checked the lifetimes and branching ratios of the taus,
and I checked the subsequent decays of pions.
I will do this in some more detail the next days,
also with particles other than taus.

Does that seem sufficient to you?

Lukas

On Mon, May 19, 2014 at 6:54 PM, Andrea Giammanco
notifications@github.comwrote:

Good job, Lukas. But so, the pythia8 option is now active by default?
Did
you validate that it does what it should, e.g. that all unstable
particles
decay and that no particle decays more than once?

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/3925#issuecomment-43528960>
.

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/3925#issuecomment-43591503>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3925#issuecomment-43591565
.

[lveldere]

what do you mean with particles being decayed twice?

On Tue, May 20, 2014 at 9:02 AM, Lukas Vanelderen <lukasvanelderen@gmail.com

wrote:

yes, this is the plan: K^0_L, B+, D+

On Tue, May 20, 2014 at 8:47 AM, Andrea Giammanco <
notifications@github.com> wrote:

It sounds good, but just to be sure, can you also try with some more
unstable particles, like B+?

---

Andrea Giammanco
Office phone: +32 10 478185
Mobiles: +32 493 581662 (BE), +41 76 2323672 (CH), +39 349 5552471 (IT), +972
546307196 (IL)

---

From: lveldere [notifications@github.com]
Sent: 20 May 2014 08:46
To: cms-sw/cmssw
Cc: Andrea Giammanco
Subject: Re: [cmssw] FastSim: ParticleDecays: fixed bugs to pythia8
option, made pythia8 opti... (#3925)

Hi Andrea

I validated things with a particle gun.
I shot taus into the detector with a plain particle gun
(no pythia particle gun, so no decays done before FastSim)
I checked the lifetimes and branching ratios of the taus,
and I checked the subsequent decays of pions.
I will do this in some more detail the next days,
also with particles other than taus.

Does that seem sufficient to you?

Lukas

On Mon, May 19, 2014 at 6:54 PM, Andrea Giammanco
notifications@github.comwrote:

Good job, Lukas. But so, the pythia8 option is now active by default?
Did
you validate that it does what it should, e.g. that all unstable
particles
decay and that no particle decays more than once?

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/3925#issuecomment-43528960>
.

—
Reply to this email directly or view it on GitHub<
https://github.com/cms-sw/cmssw/pull/3925#issuecomment-43591503>.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3925#issuecomment-43591565
.

[giamman]

I refer to a problem that I had with my failed implementation: while some particles didn't decay at all, other particles were never removed by the particle stack after decaying and therefore were decayed multiple times during their traversal of the detector.
I see that your implementation is completely different, and most likely it is the correct one, but one never knows! :)

[nclopezo]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-%20lveldere:fastsim-decayer-use-pythia8/1579/summary.html

There is a DAS Failure in workflow 50101.0

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[lveldere]

replaced by #3989