Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Fix the mismatch in transition ID for idealGeo backport #39290

Merged
merged 1 commit into from Sep 4, 2022

Conversation

fabferro
Copy link
Contributor

@fabferro fabferro commented Sep 2, 2022

PR description:

This PR fixes an error caused by loading misaligned geometry record together with the aligned geometry record and hit the transitionID error:

The transition ID stored in the ESGetToken does not match the transition where the token is being used

This is happens if a user set buildMisalignedGeometry=True in CTPPSGeometryESModule.cc

Backport of PR #39264

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

A new Pull Request was created by @fabferro (Fabrizio Ferro) for CMSSW_12_4_X.

It involves the following packages:

  • Geometry/VeryForwardGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @ianna, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabferro
Copy link
Contributor Author

fabferro commented Sep 2, 2022

@michael-pitt FYI

@civanch
Copy link
Contributor

civanch commented Sep 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8232eb/27302/summary.html
COMMIT: 3e20cbb
CMSSW: CMSSW_12_4_X_2022-09-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39290/27302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677280
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3677244
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Sep 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 4, 2022

+1

@cmsbuild cmsbuild merged commit 1fe6c94 into cms-sw:CMSSW_12_4_X Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants