Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alpaka::allocMappedBuf memory functions [12.5.x] #39312

Merged
merged 2 commits into from Sep 7, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 5, 2022

PR description:

Update and extend the use of the alpaka::allocMappedBuf functions following the update of the Alpaka external to 2022.09.02 / b518e8c943a8.

Clean up whitespace, comments, and unused dependencies.

PR validation:

Integration tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #39311 .

Update and extend the use of alpaka::allocMappedBuf functions following
the update of the Alpaka external to 2022.09.02 / b518e8c943a8.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_5_X.

It involves the following packages:

  • DataFormats/Portable (heterogeneous)
  • DataFormats/PortableTestObjects (heterogeneous)
  • HeterogeneousCore/AlpakaInterface (heterogeneous)
  • HeterogeneousCore/AlpakaTest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard changed the title Alpaka framework Update alpaka::allocMappedBuf memory functions [12.5.x] Sep 5, 2022
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 5, 2022

please test with cms-sw/cmsdist#8069

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f2b78/27347/summary.html
COMMIT: da2b7bc
CMSSW: CMSSW_12_5_X_2022-09-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39312/27347/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f2b78/27347/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f2b78/27347/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695668
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 6, 2022

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Sep 7, 2022

+1

@cmsbuild cmsbuild merged commit 50fe088 into cms-sw:CMSSW_12_5_X Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants