Revive the green status on the lumi-based plots in GEM onlineDQM, a backport to 12_4_X

[quark2]

PR description:

The green status on the lumi-block-based status plot was discarded before, but end-users pointed out that the green status is more useful than the expectation. So, it is decided to revive the function.

PR validation:

Test are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True

@jshlee @watson-ij @seungjin-yang

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #39310 to CMSSW_12_4_X

[cmsbuild]

A new Pull Request was created by @quark2 for CMSSW_12_4_X.

It involves the following packages:

• DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Revive the green status on the lumi-based plots in GEM onlineDQM #39310

[perrotta]

backport of #39310

[emanueleusai]

please test

[emanueleusai]

testing at P5, too

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-448896/27417/summary.html
COMMIT: 6f91709
CMSSW: CMSSW_12_4_X_2022-09-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39326/27417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677280
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677244
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[francescobrivio]

@quark2 is this intended to be deployed at P5 for data-taking as soon as possible?
Thanks!
Francesco (as ORM)

[syuvivida]

@quark2 we test this PR at playback using run 357900. Attached is the figure. Is one of the lumi-based figures OK? 05-GE21-P-L2? All others look green now. It's also true that before this PR, 05-GE21-P-L2 is completely red.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

urgent

• for next 12_4_X

[syuvivida]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

hold

• @quark2 your feedback is needed to confirm if the output of this PR is as expected, please see: Revive the green status on the lumi-based plots in GEM onlineDQM, a backport to 12_4_X #39326 (comment)

[cmsbuild]

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[quark2]

Hi @syuvivida,

If you are asking about the appearance of green stuffs on the lumi based plots, that's exactly what this PR makes. Meanwhile, the red bins should be already there before (and after) this PR.

Best regards,
Byeonghak Ko

[syuvivida]

Hi Byeonghak @quark2
ah, yes, I know the green figures for lumi-based plots are what the PR is for. How about the top right figure (the rightmost figure in the first row from the top: 5-GE21-P-L2, that one seems mostly empty? Is it OK?

[quark2]

Yep, that's right. It's because currently GE21 station has only one chamber in P5.

[francescobrivio]

unhold

• given author's answers in Revive the green status on the lumi-based plots in GEM onlineDQM, a backport to 12_4_X #39326 (comment) and Revive the green status on the lumi-based plots in GEM onlineDQM, a backport to 12_4_X #39326 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[quark2]

Hi @emanueleusai,

Can I ask when this PR will be deployed to P5? (or the charging person on it if you are not)

[syuvivida]

@quark2,
Does the GEM DQM group want to have this before the restart of LHC? As there is no beam and this PR has been merged with 12_4_X, we were thinking about waiting for the next switch of CMSSW (decided in Joint OPS). But if GEM group prefers to check the results now, the switch to include this PR can be done easily.

[quark2]

Ahh, that's okay then. Thanks!

[syuvivida]

@quark2,
sorry, just to double check, do you mean ok to wait for the next switch of CMSSW?

[quark2]

@syuvivida
Ahh, sorry for my ambiguous words...

And sorry again, it would be good to check the results now. Could you deploy it now?

[syuvivida]

@quark2,
our DQM DOC just switched the production release and now this PR is deployed at P5. Once a new run starts, it will pick up this latest production with PR 39326.

[quark2]

@syuvivida

Ahh, thanks a lot! I'll have a look.