Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce MASKING operator in triggerExpression::Parser [12_5_X] #39348

Merged

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Sep 8, 2022

backport of #39196

PR description:

This PR adds a new operator to the syntax supported by the triggerExpression::Parser class.

The new operator is called MASKING, as it allows to "mask" (or, ignore) triggers inside a given logical expression; for example, L1_* MASKING L1_Zero*copy corresponds to the OR of "all L1 seeds except for the ones matching the name pattern L1_Zero*copy".

More details on the purpose of this PR, and its implementation, can be found in #39196.

This PR does not modify the outputs of any existing wfs, and the new feature it introduces is currently unused. On the other hand, TSG might decide to use said new feature during online operations in 2022.

Merely technical. No changes expected.

PR validation:

Relies on the validation done for #39196.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39196

The new feature in this PR might be used for HLT online operations in 2022.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • HLTrigger/HLTcore (hlt)
  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Sep 8, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-905a87/27430/summary.html
COMMIT: 7499d5e
CMSSW: CMSSW_12_5_X_2022-09-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39348/27430/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695824
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695788
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Sep 8, 2022

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0afbe40 into cms-sw:CMSSW_12_5_X Sep 9, 2022
@missirol missirol deleted the devel_hltParserMaskOperator_125X branch September 9, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants