Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L1T] Backport - L1T modules/sequences/tasks renaming #39354

Merged
merged 4 commits into from Sep 15, 2022
Merged

[L1T] Backport - L1T modules/sequences/tasks renaming #39354

merged 4 commits into from Sep 15, 2022

Conversation

cecilecaillol
Copy link
Contributor

PR description:

Backport of #39244

Addressing item 1 of #39194: change L1 modules to start with l1t, sequences and tasks with L1T
Also addressing item 2 of the same issue: Fix hltTriggerSummaryAOD
Also addressing item 5 of the same issue: Verify the PSet cutset in L1TrackSelectionProducerExtended

ccaillol added 3 commits September 9, 2022 11:20
Rename L1T modules/sequences/tasks to follow conventions
eeb7cf4 
lower case l1 modules

L1 module lower case in L1 packages

l1t modules lower case

upper case Tasks, switch l1ct to l1t

Martins and Marinos comments

further renaming

further fixes

further renaming

change TTTracks to l1TTTracks

remove outdated config

further renaming

rename hlt sequences

hgcal renaming

(cherry picked from commit e68eee3)
fix renaming in SimL1EmulatorDM
443ad71 
(cherry picked from commit 01d1d01)
minor fixes to l1t renaming
33b765a 
(cherry picked from commit 65f532c)
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Sep 9, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2022 •
edited

A new Pull Request was created by @cecilecaillol for CMSSW_12_5_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQM/SiOuterTracker (dqm)
  • DQMOffline/L1Trigger (dqm, l1)
  • HLTrigger/Configuration (hlt)
  • L1Trigger/Configuration (l1)
  • L1Trigger/DemonstratorTools (l1)
  • L1Trigger/L1CaloTrigger (upgrade, l1)
  • L1Trigger/L1THGCal (upgrade, l1)
  • L1Trigger/L1THGCalUtilities (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1GMT (l1)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • L1Trigger/Phase2L1Taus (l1)
  • L1Trigger/TrackFindingTracklet (l1)
  • L1Trigger/VertexFinder (l1)
  • RecoEgamma/EgammaHLTProducers (hlt)
  • RecoTracker/TkSeedGenerator (reconstruction)
  • Validation/HGCalValidation (dqm)

@perrotta, @Martin-Grunewald, @rappoccio, @pmandrik, @missirol, @epalencia, @mandrenguyen, @emanueleusai, @ahmad3213, @cecilecaillol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @clacaputo, @syuvivida, @rvenditti, @micsucmed, @fabiocos, @rekovic, @davidlange6 can you please review it and eventually sign? Thanks.
@erikbutz, @VourMa, @felicepantaleo, @jainshilpi, @Martin-Grunewald, @bsunanda, @pfs, @trtomei, @lgray, @mmusich, @cericeci, @youyingli, @sethzenz, @missirol, @makortel, @JanFSchulte, @dgulhan, @apsallid, @HuguesBrun, @slomeo, @skinnari, @beaucero, @rociovilar, @vandreev11, @Sam-Harper, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @hatakeyamak, @jbsauvan, @ebrondol, @mtosi, @fabiocos, @arossi83, @varuns23, @valsdav, @Fedespring, @silviodonato, @sobhatta, @lecriste, @afiqaize, @gpetruc, @wrtabb, @amarini, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol cecilecaillol mentioned this pull request Sep 9, 2022
Closed
@missirol
Copy link
Contributor

backport of #39244

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-929d68/27459/summary.html
COMMIT: 33b765a
CMSSW: CMSSW_12_5_X_2022-09-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39354/27459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695824
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3695782
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

rename cfis
6f2b071 
(cherry picked from commit 7801862)
@cmsbuild
Copy link
Contributor

Pull request #39354 was updated. @perrotta, @Martin-Grunewald, @rappoccio, @pmandrik, @missirol, @epalencia, @mandrenguyen, @emanueleusai, @ahmad3213, @cecilecaillol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @clacaputo, @syuvivida, @rvenditti, @micsucmed, @fabiocos, @rekovic, @davidlange6 can you please check and sign again.

@cecilecaillol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-929d68/27537/summary.html
COMMIT: 6f2b071
CMSSW: CMSSW_12_5_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39354/27537/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695824
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695794
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor Author

+l1

@emanueleusai
Copy link
Member

+1

@AdrianoDee
Copy link
Contributor

+upgrade

@missirol
Copy link
Contributor

+hlt

  • verbatim backport

@mandrenguyen
Copy link
Contributor

+reconstruction

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit cfba562 into cms-sw:CMSSW_12_5_X Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok dqm-approved fully-signed hlt-approved l1-approved operations-approved orp-approved reconstruction-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cecilecaillol @cmsbuild @missirol @mandrenguyen @emanueleusai @AdrianoDee @perrotta