[124X] Fixed RP IDs in the PPS alignment harvester

[MatiXOfficial]

PR description:

See #39358

PR validation:

See #39358

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39358

[cmsbuild]

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for CMSSW_12_4_X.

It involves the following packages:

• CalibPPS/AlignmentGlobal (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixed RP IDs in the PPS alignment harvester #39358

[tvami]

backport of #39358

[tvami]

type bugfix,ctpps

[tvami]

urgent

• should go into the next 12_4_X

[tvami]

test parameters:

• workflows = 1042,1045

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908c55/27452/summary.html
COMMIT: 98c69b6
CMSSW: CMSSW_12_4_X_2022-09-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39361/27452/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-908c55/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-908c55/1045.0_RunRawPPS2022B+RunRawPPS2022B+TIER0EXPPPSCALRUN3+ALCASPLITPPSALIGRUN3+ALCAHARVDPPSALIGRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3678080
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3678056
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 216 log files, 45 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• backport-ok
• tests pass
• differences only in MTD

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1