Simplify L1TPhase2MuonOffline and fix L1TRate_Offline and L1TStage2CaloLayer2Offline [CMSSW_12_5_X]

[perrotta]

PR description:

This PR comprehensively backports #39283 and #39297 by cherry picking the very same commits from them.

At the end, this PR does not apply any bug fix (the one originally included in #39283 was lately removed with #3929 because it was not correct) but clean up and simplify largely the structure of the class.

Since Phase2 L1T production is expected to come with 12_5_X, and there are still quite several issues to fix in that code overall, I think it can be better to keep the versions of the code synchronized between the two release cycles, and therefore also merge this PR. Moreover, it allows some performance improvement for that code.

=== Later comment:

I realized that not even #39261 was backported to 12_5_X, and that was a real bug fix for the L1T Phase2 DQM. I cherry picked also that PR here, then.

PR validation:

It builds, and it was already tested in master

backport of #39283, #39297 and #39261

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_5_X.

It involves the following packages:

• DQMOffline/L1Trigger (dqm, l1)

@epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Revert the requirement of having an associated L1T muon in L1TPhase2MuonOffline::matchMuonsToGen #39297

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6262ac/27461/summary.html
COMMIT: 28146c1
CMSSW: CMSSW_12_5_X_2022-09-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39363/27461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695824
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695782
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #39363 was updated. @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @rekovic, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

[perrotta]

I realized that not even #39261 was backported to 12_5_X, and that was a real bug fix for the L1T Phase2 DQM. I cherry picked also that PR here, then.

[perrotta]

please test

[perrotta]

type bugfix

[perrotta]

backport of #39297

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6262ac/27462/summary.html
COMMIT: 1a084d9
CMSSW: CMSSW_12_5_X_2022-09-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39363/27462/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3695824
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695788
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1