Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation in Geant4 IBs #39376

Merged
merged 2 commits into from Sep 14, 2022
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Sep 13, 2022

PR description:

Fixed compilation problem in Geant4 IBs. Should not affect mainstream.

PR validation:

private

@civanch
Copy link
Contributor Author

civanch commented Sep 13, 2022

bug-fix

@civanch
Copy link
Contributor Author

civanch commented Sep 13, 2022

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39376/32082

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

  • SimG4Core/PhysicsLists (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f2fdc/27501/summary.html
COMMIT: fa4c069
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-09-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39376/27501/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Leaving Package Utilities/RelMon
>> Package Utilities/RelMon built
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
>> Entering Package src/BigProducts/Simulation
>> Building  big plugin tmp/el8_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so
c++: error: objs/el8_amd64_gcc10/SimG4CorePhysicsLists.obj: No such file or directory
gmake: *** [tmp/el8_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so] Error 1
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built
>> Leaving Package src/BigProducts/Simulation
>> Package src/BigProducts/Simulation built


@iarspider
Copy link
Contributor

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39376/32086

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39376 was updated. @civanch, @mdhildreth can you please check and sign again.

@cms-sw cms-sw deleted a comment from iarspider Sep 13, 2022
@civanch
Copy link
Contributor Author

civanch commented Sep 13, 2022

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@smuzaffar
Copy link
Contributor

please test

lets start tests for normal IBs too

@smuzaffar
Copy link
Contributor

test parameters:

  • addpkg = SimG4Core,Alignment/LaserAlignmentSimulation

@smuzaffar
Copy link
Contributor

please test for CMSSW_12_6_G4VECGEOM_X/el8_amd64_gcc10

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f2fdc/27505/summary.html
COMMIT: eb316a9
CMSSW: CMSSW_12_6_G4VECGEOM_X_2022-09-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39376/27505/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 35034.035034.0_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D77+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 28234.028234.0_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal/step1_TTbar_14TeV+2026D60+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

@civanch
Copy link
Contributor Author

civanch commented Sep 13, 2022

These problems were in previous versions of G4VECGEOM.

@civanch
Copy link
Contributor Author

civanch commented Sep 13, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f2fdc/27504/summary.html
COMMIT: eb316a9
CMSSW: CMSSW_12_6_X_2022-09-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39376/27504/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618326
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618293
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants