Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add summary plot for differences for all coordinates in the Tracker Alignment Payload Inspector #39424

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 16, 2022

PR description:

The goal of this PR is to add a new class to the TrackerAlignment_PayloadInspector class in order to display at one time in one canavs all the 6 rigid body degrees of freedom differences for a couple of different tracker alignment paylaods.

PR validation:

Tested with the commands:

getPayloadData.py \
    --plugin pluginTrackerAlignment_PayloadInspector \
    --plot plot_TrackerAlignmentComparatorTwoTags \
    --tag TrackerAlignment_collisions22_v3 \
    --tagtwo TrackerAlignment_PCL_byRun_v2_express \
    --time_type Run \
    --iovs '{"start_iov": "357710", "end_iov": "357710"}' \
    --iovstwo '{"start_iov": "358156", "end_iov": "358156"}' \
    --db Prod \
    --test ;

and obtained the following plot:

image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39424/32131

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/AlignmentPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 16, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a67dbe/27610/summary.html
COMMIT: d235a1f
CMSSW: CMSSW_12_6_X_2022-09-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39424/27610/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618332
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618302
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 16, 2022

+db

  • unit test testing this passes

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 66e5569 into cms-sw:master Sep 17, 2022
@mmusich mmusich deleted the addSummaryPlotForAllPartitionsAlignment branch September 17, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants