Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[124X] Fix double counting in HepMC to G4 handoff" #39467

Merged
merged 1 commit into from Sep 21, 2022

Conversation

perrotta
Copy link
Contributor

According to the discussion in https://its.cern.ch/jira/browse/PDMVRELVALS-165 we:

Now pdmv can use CMSSW_12_4_9_patch1 to produce the validation samples needed

Reverts #39440

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_4_X.

It involves the following packages:

  • SimG4Core/Generators (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 30fad7e into CMSSW_12_4_X Sep 21, 2022
@perrotta perrotta deleted the revert-39440-Fix2xMIPBugInGen_Backporrt124X branch September 21, 2022 13:48
@sunilUIET
Copy link
Contributor

Hi,

As discussed in jira, a standard validation was performed for this PR. Reports received from different PAG/POG is OK.

Sunil (for pdmV)

@perrotta
Copy link
Contributor Author

@sunilUIET thank you for reporting.
However, I think you validated the fix (i.e. #39468 in 12_4_X, which backports #39427 in master, not this "revert of the fix".
Could you please add your comment to the correct PRs, so that action on them can be taken?
I think this will be further discussed at tomorrow's ORP anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants