Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robustify TkHistoMap and related unit tests #39469

Merged
merged 1 commit into from Sep 22, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 21, 2022

resolves #39455

PR description:

Title says it all, see analysis at #39455 (comment).
Supply also a real input file for the unit test.

PR validation:

Relies on the unit tests.
Run successfully:

scram b runtests_test_TkHistoMap 

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2022

type trk, bug-fix

@Dr15Jones
Copy link
Contributor

@mmusich thanks for the quick fix!

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39469/32195

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)
  • DQM/SiStripCommon (dqm)

@malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@echabert, @hdelanno, @erikbutz, @sroychow, @robervalwalsh, @gbenelli, @tocheng, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus, @arossi83 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39469/32198

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39469 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47a018/27714/summary.html
COMMIT: 6d868f6
CMSSW: CMSSW_12_6_X_2022-09-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39469/27714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3624368
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3624335
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 21, 2022

+alca

  • test pass, PR according to the desc

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b9c99f9 into cms-sw:master Sep 22, 2022
@mmusich mmusich deleted the robustifyTkHistoMap branch September 22, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insufficient error handling in TkHistoMap::fillFromAscii
6 participants