New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
robustify TkHistoMap
and related unit tests
#39469
Conversation
type trk, bug-fix |
@mmusich thanks for the quick fix! |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39469/32195
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
6ed0ba6
to
6d868f6
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39469/32198
|
Pull request #39469 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47a018/27714/summary.html Comparison SummarySummary:
|
+alca
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
resolves #39455
PR description:
Title says it all, see analysis at #39455 (comment).
Supply also a real input file for the unit test.
PR validation:
Relies on the unit tests.
Run successfully:
scram b runtests_test_TkHistoMap
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A