[SIMULATION] [GCC12] Fix build warnings

[smuzaffar]

This should fix the build warnings for gcc12 IBs

In copy constructor 'HFShower::Hit::Hit(const HFShower::Hit&)',
    inlined from 'void std::__new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = HFShower::Hit; _Args = {const HFShower::Hit&}; _Tp = HFShower::Hit]' at ...external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/include/c++/12.2.1/bits/new_allocator.h:175:4,
    inlined from 'static void std::allocator_traits<std::allocator<_CharT> >::construct(allocator_type&, _Up*, _Args&& ...) [with _Up = HFShower::Hit; _Args = {const HFShower::Hit&}; _Tp = HFShower::Hit]' at ...external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/include/c++/12.2.1/bits/alloc_traits.h:516:17,
    inlined from 'void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = HFShower::Hit; _Alloc = std::allocator<HFShower::Hit>]' at ...external/gcc/12.2.0-f8ec77b592790702d83afb7106a458e3/include/c++/12.2.1/bits/stl_vector.h:1281:30,
    inlined from 'std::vector<HFShower::Hit> HFShower::getHits(const G4Step*, bool)' at ...cms/cmssw/CMSSW_12_6_X_2022-09-24-1100/src/SimG4CMS/Calo/src/HFShower.cc:348:19:
  ...cms/cmssw/CMSSW_12_6_X_2022-09-24-1100/src/SimG4CMS/Calo/interface/HFShower.h:32:10: warning: 'hit.HFShower::Hit::depth' may be used uninitialized [-Wmaybe-uninitialized]
    32 |   struct Hit {
      |          ^~~
...cms/cmssw/CMSSW_12_6_X_2022-09-24-1100/src/SimG4CMS/Calo/src/HFShower.cc: In member function 'std::vector<HFShower::Hit> HFShower::getHits(const G4Step*, bool)':
...cms/cmssw/CMSSW_12_6_X_2022-09-24-1100/src/SimG4CMS/Calo/src/HFShower.cc:280:17: note: 'hit' declared here
  280 |   HFShower::Hit hit;
------
CMSSW_12_6_X_2022-09-24-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelChargeReweightingAlgorithm.cc: In constructor 'SiPixelChargeReweightingAlgorithm::SiPixelChargeReweightingAlgorithm(const edm::ParameterSet&, edm::ConsumesCollector)':
  CMSSW_12_6_X_2022-09-24-1100/src/SimTracker/SiPixelDigitizer/plugins/SiPixelChargeReweightingAlgorithm.cc:65:15: warning: member 'SiPixelChargeReweightingAlgorithm::templateStores_' is used uninitialized [-Wuninitialized]
    65 |       templ2D(templateStores_),

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39523/32287

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• SimG4CMS/Calo (simulation)
• SimTracker/SiPixelDigitizer (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@tvami, @fabiocos, @VourMa, @missirol, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @bsunanda, @OzAmram, @thomreis, @ferencek, @mtosi, @mmusich, @dkotlins, @threus, @dgulhan, @slomeo, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-218d86/27814/summary.html
COMMIT: 99e00f2
CMSSW: CMSSW_12_6_X_2022-09-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39523/27814/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3624368
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3624343
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39523/32304

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #39523 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-218d86/27845/summary.html
COMMIT: 9c256b2
CMSSW: CMSSW_12_6_X_2022-09-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39523/27845/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-218d86/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3433154
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3433132
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1