Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing unit tests after #38702 merge (Drop of geometry D49) #39535

Merged
merged 1 commit into from Oct 1, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 29, 2022

PR description:

Title says it all.
Attempt to fix problem at #38594 (comment).

PR validation:

Run unit tests, which are not completely OK yet.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39535/32309

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)
  • SLHCUpgradeSimulations/Geometry (geometry, upgrade)
  • SimTracker/TrackerMaterialAnalysis (simulation)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@youyingli, @fabiocos, @VourMa, @vargasa, @mtosi, @apsallid, @GiacomoSguazzoni, @JanFSchulte, @rovere, @dgulhan, @missirol, @bsunanda, @trtomei, @mmusich, @VinInn, @threus, @beaucero, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2022

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39535/32311

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #39535 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@mmusich mmusich marked this pull request as ready for review September 29, 2022 12:43
@mmusich
Copy link
Contributor Author

mmusich commented Sep 29, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f680da/27848/summary.html
COMMIT: 66b7bb5
CMSSW: CMSSW_12_6_X_2022-09-29-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39535/27848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f680da/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3433154
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3433123
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Fixes for unit test after phase-2 geometry clean up. No change is expected in comparison.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2022

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Sep 30, 2022

@cms-sw/simulation-l2 @cms-sw/geometry-l2 please take a look.

@civanch
Copy link
Contributor

civanch commented Sep 30, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 1, 2022

+1

@cmsbuild cmsbuild merged commit 510d0de into cms-sw:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants