Add helper functions for alpaka kernels #39546

fwyzard · 2022-09-29T22:28:27Z

PR description:

Add helper functions for:

performing an integer division with rounding up, or rounding a value to the next multiple of an integer;
creating an efficient work division, assigning the number of work items either to the number of GPU threads or CPU elements;
perform a scalar or N-dimensional strided loop within a kernel, based on the grid size and number of elements.

Update the alpaka tests to use the new helper functions.

PR validation:

Unit tests pass.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to CMSSW_12_5_X for the Alpaka migration.

fwyzard · 2022-09-29T22:29:00Z

Should be rebased after merging #39532.

cmsbuild · 2022-09-29T22:35:12Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39546/32328

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CUDADataFormats/PortableTestObjects/interface/TestDeviceCollection.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File CUDADataFormats/PortableTestObjects/interface/TestHostCollection.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/BuildFile.xml modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/interface/TestSoA.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/src/classes_def.xml modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/SoATemplate/interface/SoACommon.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/SoATemplate/interface/SoALayout.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaCore/interface/ContextState.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaCore/interface/chooseDevice.h modified in PR(s): Require the AlpakaService to be enabled before running on a Device #39498, Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/plugins/TestAlpakaAnalyzer.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/test/testHeterogeneousCoreAlpakaTestWriteRead.sh modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestAlgo.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestAlgo.cu modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestPortableAnalyzer.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/test/testHeterogeneousCoreCUDATestWriteRead.sh modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39546/32328/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39546/32328/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

fwyzard · 2022-09-30T04:34:10Z

enable gpu

fwyzard · 2022-09-30T04:34:23Z

please test with cms-sw/cmsdist#8107

cmsbuild · 2022-09-30T04:41:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39546/32329

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CUDADataFormats/PortableTestObjects/interface/TestDeviceCollection.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File CUDADataFormats/PortableTestObjects/interface/TestHostCollection.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/BuildFile.xml modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/interface/TestSoA.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/PortableTestObjects/src/classes_def.xml modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/SoATemplate/interface/SoACommon.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File DataFormats/SoATemplate/interface/SoALayout.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaCore/interface/ContextState.h modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaCore/interface/chooseDevice.h modified in PR(s): Require the AlpakaService to be enabled before running on a Device #39498, Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/plugins/TestAlpakaAnalyzer.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/plugins/alpaka/TestAlgo.dev.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/AlpakaTest/test/testHeterogeneousCoreAlpakaTestWriteRead.sh modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestAlgo.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestAlgo.cu modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/plugins/TestPortableAnalyzer.cc modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532
- File HeterogeneousCore/CUDATest/test/testHeterogeneousCoreCUDATestWriteRead.sh modified in PR(s): Read SoA scalars and Eigen columns from a ROOT streamer #39532

cmsbuild · 2022-09-30T04:41:57Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CUDADataFormats/PortableTestObjects (heterogeneous)
DataFormats/PortableTestObjects (heterogeneous)
DataFormats/SoATemplate (heterogeneous)
HeterogeneousCore/AlpakaCore (heterogeneous)
HeterogeneousCore/AlpakaInterface (heterogeneous)
HeterogeneousCore/AlpakaTest (heterogeneous)
HeterogeneousCore/CUDATest (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-09-30T09:44:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce334d/27870/summary.html
COMMIT: 58de740
CMSSW: CMSSW_12_6_X_2022-09-29-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39546/27870/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce334d/27870/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce334d/27870/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce334d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3433154
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3433108
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 74
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19802
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

fwyzard · 2022-09-30T20:57:37Z

please test with cms-sw/cmsdist#8107

fwyzard · 2022-10-03T16:18:32Z

enable gpu

fwyzard · 2022-10-03T16:18:37Z

please test

cmsbuild · 2022-10-03T16:24:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39546/32371

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-03T16:24:55Z

Pull request #39546 was updated. @makortel, @fwyzard can you please check and sign again.

fwyzard · 2022-10-03T16:30:34Z

+heterogeneous

cmsbuild · 2022-10-03T16:31:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-10-03T22:01:08Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce334d/27943/summary.html
COMMIT: 355d9d3
CMSSW: CMSSW_12_6_X_2022-10-03-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39546/27943/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

250202.181250202.181_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step2_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log
500204.0500204.0_QQH1352T_13+QQH1352T_13INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50/step2_QQH1352T_13+QQH1352T_13INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50.log
500207.0500207.0_NuGun_UP15+NuGun_UP15INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50/step2_NuGun_UP15+NuGun_UP15INPUT+DIGIPRMXUP15_PU50+RECOPRMXUP15_PU50+HARVESTUP15_PU50.log

Expand to see more relval errors ...

250202.171
250202.172
250202.2
250202.5
250203.0
250203.18
250204.0
250204.17
250205.0
250206.17
250206.181
250207.0
250207.17
250207.18
250208.17
500202.0
500203.0
500206.0

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce334d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3432650
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3432628
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19867
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

fwyzard · 2022-10-03T22:04:41Z

I assume the relvals/input failures are unrelated to these changes ?

fwyzard · 2022-10-03T22:04:51Z

please test

cmsbuild · 2022-10-04T02:37:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce334d/27955/summary.html
COMMIT: 355d9d3
CMSSW: CMSSW_12_6_X_2022-10-03-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39546/27955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ce334d/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3432650
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3432622
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19876
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19868
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

perrotta · 2022-10-04T07:48:43Z

+1

cmsbuild added this to the CMSSW_12_6_X milestone Sep 29, 2022

cmsbuild added code-checks-pending heterogeneous-pending orp-pending pending-signatures tests-pending labels Sep 29, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 29, 2022

fwyzard force-pushed the alpaka_framework_part2 branch from ad3a783 to 58de740 Compare September 30, 2022 04:33

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 30, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Sep 30, 2022

fwyzard mentioned this pull request Sep 30, 2022

Add helper functions for alpaka kernels [12.5.x] #39547

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2022

fwyzard force-pushed the alpaka_framework_part2 branch from 58de740 to 05286d1 Compare September 30, 2022 20:57

cmsbuild removed tests-approved requires-external labels Sep 30, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2022

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Oct 3, 2022

cmsbuild mentioned this pull request Oct 3, 2022

Require the AlpakaService to be enabled before running on a Device #39498

Merged

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 3, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 4, 2022

cmsbuild merged commit 89aa460 into cms-sw:master Oct 4, 2022

fwyzard deleted the alpaka_framework_part2 branch October 11, 2022 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helper functions for alpaka kernels #39546

Add helper functions for alpaka kernels #39546

fwyzard commented Sep 29, 2022

fwyzard commented Sep 29, 2022

cmsbuild commented Sep 29, 2022

fwyzard commented Sep 30, 2022

fwyzard commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

fwyzard commented Sep 30, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 4, 2022

perrotta commented Oct 4, 2022

Add helper functions for alpaka kernels #39546

Add helper functions for alpaka kernels #39546

Conversation

fwyzard commented Sep 29, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

fwyzard commented Sep 29, 2022

cmsbuild commented Sep 29, 2022

fwyzard commented Sep 30, 2022

fwyzard commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

cmsbuild commented Sep 30, 2022

Comparison Summary

GPU Comparison Summary

fwyzard commented Sep 30, 2022

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

cmsbuild commented Oct 3, 2022

RelVals-INPUT

Comparison Summary

GPU Comparison Summary

fwyzard commented Oct 3, 2022

fwyzard commented Oct 3, 2022

cmsbuild commented Oct 4, 2022

Comparison Summary

GPU Comparison Summary

perrotta commented Oct 4, 2022