Added transformAsync ability to modules

[Dr15Jones]

PR description:

This is similar to transform except two actions are specified similar to acquire/produce.

PR validation:

Code compiles and all framework unit tests pass.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39557/32347

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/global/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/global/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/global/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/stream/ProducingModuleAdaptorBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/global/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/global/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/limited/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/limited/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/one/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/one/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/stream/ProducingModuleAdaptorBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/test/global_filter_t.cppunit.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/test/global_producer_t.cppunit.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement support for concurrent runs in the Framework #38801

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/Integration (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53fe2e/27890/summary.html
COMMIT: 62340cc
CMSSW: CMSSW_12_6_X_2022-09-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39557/27890/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39557/32351

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/global/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/global/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/global/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/limited/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/EDFilterBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/EDProducerBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/one/implementors.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/interface/stream/ProducingModuleAdaptorBase.h modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/global/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/global/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/limited/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/limited/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/one/EDFilterBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/one/EDProducerBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/src/stream/ProducingModuleAdaptorBase.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/test/global_filter_t.cppunit.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Framework/test/global_producer_t.cppunit.cc modified in PR(s): Implement support for concurrent runs in the Framework #38801
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement support for concurrent runs in the Framework #38801

[cmsbuild]

Pull request #39557 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39557/32567

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/WorkerT.cc modified in PR(s): Removed use of edm::EDFilter & edm::EDProducer #39710

[cmsbuild]

Pull request #39557 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[makortel]

@cmsbuild, please abort

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53fe2e/28243/summary.html
COMMIT: 8924cf4
CMSSW: CMSSW_12_6_X_2022-10-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39557/28243/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3392309
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3392278
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

@Dr15Jones can you give a bit more explanation here? It's a relatively in-depth PR that I'm not fully understanding. Was there a talk or something we can look at?

[makortel]

@rappoccio The Transformer ability was added in #38454 with a synchronous interface. Addition of an asynchronous interface was discussed in #38454 (comment) (and onwards).

The Transformer ability is used in #39428 for implicit/automated data product transfers from device memory space to host memory space. After we get this PR merged, I'll make use of the asynchronous interface in #39428 to make the device-to-host transfers asynchronous.

[rappoccio]

+1