Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ESHandle headers where needed in CondTools/RunInfo/plugins #39569

Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Oct 1, 2022

PR description:

Move ESHandle headers only where needed in CondTools/RunInfo/plugins

PR validation:

It compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39569/32352

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • CondTools/RunInfo (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Oct 1, 2022

please test

@perrotta perrotta changed the title Move ESHandle headers where needed Move ESHandle headers where needed in CondTools/RunInfo/plugins Oct 1, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556f22/27905/summary.html
COMMIT: d6af27a
CMSSW: CMSSW_12_6_X_2022-10-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39569/27905/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-556f22/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432650
  • DQMHistoTests: Total failures: 111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3432517
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 49 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 2, 2022

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

perrotta commented Oct 2, 2022

+1

@cmsbuild cmsbuild merged commit b63b45c into cms-sw:master Oct 2, 2022
@perrotta perrotta deleted the cleanupHeaderIncludesInRunInfoPlugins branch October 2, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants