Reduce the ECAL and HCAL GPU memory usage [12.4.x]

[fwyzard]

PR description:

Allocate memory buffers based on the actual number of events, instead of always allocating the maximum size.

Declare the the obsolete parameters as optional, and ignore them if they are present.

Reduces the total GPU memory from running the HLT with 4 jobs with 32 threads and 32 streams by about 25%:

release	total	reserved	used	free
CMSSW_12_4_9	15360 MB	449 MB	10678 - 10090 MB	4231 - 4819 MB
with #39580	15360 MB	449 MB	7366 - 8056 MB	7543 - 6853 MB

Thanks to @VinInn for finding the issue and for the changes.

PR validation:

The full HLT menu runs on GPU (with 12.4.9 plus #39580) without issues.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39577.

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HcalRecProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rchatter, @argiro, @missirol, @bsunanda, @thomreis, @simonepigazzini, @mariadalfonso, @abdoulline this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Pull request #39580 was updated. @cmsbuild, @missirol, @mandrenguyen, @clacaputo, @Martin-Grunewald can you please check and sign again.

[cmsbuild]

Pull request #39580 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[cmsbuild]

Pull request #39580 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again.

[fwyzard]

enable gpu

[fwyzard]

please test

[clacaputo]

it seems the test is stuck and build aborted
22:26:36 Build timed out (after 600 minutes). Marking the build as aborted.

[clacaputo]

please abort

[clacaputo]

enable gpu

[clacaputo]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9dc2/28012/summary.html
COMMIT: 7d941ac
CMSSW: CMSSW_12_4_X_2022-10-04-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39580/28012/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677402
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677378
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19868
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 1 / 3 workflows

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Differences wrt to master are due to Reduce the ECAL and HCAL GPU memory usage [12.4.x] #39580 (comment): ok!