Removed unnecessary includes in CommonTools/ParticleFlow

[Dr15Jones]

PR description:

Removed include and commented include of deprecated header.

PR validation:

Code compiles without CMS deprecation warnings.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39582/32370

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• CommonTools/ParticleFlow (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @missirol, @gkasieczka, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-320694/27944/summary.html
COMMIT: 318a995
CMSSW: CMSSW_12_6_X_2022-10-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39582/27944/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 10007.0DAS Error
• 10008.0DAS Error
• 10009.0DAS Error

Expand to see more relval errors ...

• 10024.0
• 10024.5
• 10025.0
• 10042.0
• 10071.0
• 10224.0
• 10224.15
• 10424.0
• 10802.0
• 10805.31
• 10807.0
• 10808.0
• 10809.0
• 10824.0
• 10824.501
• 10824.505
• 10824.8
• 10842.0
• 10871.0
• 11024.6
• 11224.0

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-320694/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3432650
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3432622
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

merge

• removing unused and deprecated headers, even commented out, can be merged even without an explicit @cms-sw/reconstruction-l2 ,signature to clean up the long queue a bit
• RelValInput errors are not related and should not retrigger new tests

[jfernan2]

+1
(for the records)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).