[Fix] Decrease cut on min number of hits only in RKFittingSmoother

[mmasciov]

PR description:

This PR fixes one feature of PR #39578, as highlighted in this comment.
In particular, the lower cut on min number of hits is now applied only for RKFittingSmoother, used in mergedDuplicateTracks.

[slava77]

after the codechecks is out, we should run with #39578
to get combined comparisons for pre3

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39611/32408

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

• TrackingTools/TrackFitters (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @andrea21z, @JanFSchulte, @jhgoh, @missirol, @HuguesBrun, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @Fedespring, @lecriste, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test with #39578

[mandrenguyen]

How about running the profiling again? Maybe the increase of fakes was responsible for the timing increase in the phase 2 wf

[mmusich]

type bug-fix, tracking

[perrotta]

Thank you @mmasciov !

[perrotta]

urgent

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b41b4e/27995/summary.html
COMMIT: ca47429
CMSSW: CMSSW_12_6_X_2022-10-04-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39611/27995/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /pool/condor/dir_25029/jenkins/workspace/compare-root-files-short-matrix/data/PR-b41b4e/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 13187 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3432650
• DQMHistoTests: Total failures: 75099
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3357529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[slava77]

enable profiling

[slava77]

@cmsbuild please test with #39578

[slava77]

Reco comparison results: 13187 differences found in the comparisons

the diffs the refittedStandaloneMuons that puzzled me in 12434.0 are now gone.

I'm haven't actually seen anything obvious in the electron plots before to point to an impact of fixing/recovering GsfElectronFittingSmoother.
But this PR should the issue from first principles (config dumps).

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b41b4e/28001/summary.html
COMMIT: ca47429
CMSSW: CMSSW_12_6_X_2022-10-04-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39611/28001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b41b4e/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 13179 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3432650
• DQMHistoTests: Total failures: 68772
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363856
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
CPU time of the phase 2 workflow now goes down instead of up, as it did with only #39578

[perrotta]

ping bot

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1