Add Service type in an exception message from ServiceRegistry #39636

makortel · 2022-10-05T16:55:13Z

PR description:

This PR adds the Service type as part of the exception message when a ServiceRegistry has not been set for the current thread. This information could help debugging semi-rare failures in HLT tests that were reported in #38801 (comment) .

PR validation:

Code compiles

cmsbuild · 2022-10-05T17:01:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39636/32434

This PR adds an extra 12KB to repository

cmsbuild · 2022-10-05T17:01:57Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/ServiceRegistry (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

makortel · 2022-10-05T17:04:05Z

@cmsbuild, please test

FWCore/ServiceRegistry/interface/ServiceRegistry.h

makortel · 2022-10-05T18:48:59Z

@cmsbuild, please abort

cmsbuild · 2022-10-05T18:58:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39636/32439

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-05T18:58:34Z

Pull request #39636 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

makortel · 2022-10-05T19:11:23Z

@cmsbuild, please test

cmsbuild · 2022-10-06T14:06:19Z

-1

Failed Tests: UnitTests RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0130f6/28033/summary.html
COMMIT: 730ad74
CMSSW: CMSSW_12_6_X_2022-10-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39636/28033/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test condTestRegression had ERRORS
---> test SiStripDAQ_O2O_test had ERRORS

RelVals-INPUT

140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

AddOn Tests

hlt_mc_HIoncmsRun /cvmfs/cms-ib.cern.ch/nweek-02753/el8_amd64_gcc10/cms/cmssw-patch/CMSSW_12_6_X_2022-10-05-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu Oct 6 12:37:00 2022-date Thu Oct 6 12:31:00 2022 s - exit: 23040

Comparison Summary

There are some workflows for which there are errors in the baseline:
10224.15 step 5
11634.15 step 3
140.002 step 3
140.034 step 3
140.116 step 3
25202.15 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0130f6/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3391103
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3391075
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-10-06T15:48:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-10-07T19:08:14Z

Hoping the failed tests are spurious, will try again.

rappoccio · 2022-10-07T19:08:20Z

please test

cmsbuild · 2022-10-08T03:25:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0130f6/28113/summary.html
COMMIT: 730ad74
CMSSW: CMSSW_12_6_X_2022-10-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39636/28113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0130f6/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3391103
DQMHistoTests: Total failures: 90
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3390991
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

smuzaffar · 2022-10-09T11:47:17Z

For AddOn tests the link to hlt_mc_HIon is wrong (@smuzaffar), the failed test was actually hlt_data_HIon. This was actually lucky because now we see the effect of this PR

thanks for catching this. The reason behind this wrong link is that both hlt_data_HIon and hlt_mc_HIon use same logfile names ( first 150 characters of the command )

hlt_data_HIon/cmsRun__cvmfs_cms-ib.cern.ch_nweek-02753_el8_amd64_gcc10_cms_cmssw-patch_CMSSW_12_6_X_2022-10-05-1100_src_HLTrigger_Configuration_test_OnLine_HLT_HIon.log
hlt_mc_HIon/cmsRun__cvmfs_cms-ib.cern.ch_nweek-02753_el8_amd64_gcc10_cms_cmssw-patch_CMSSW_12_6_X_2022-10-05-1100_src_HLTrigger_Configuration_test_OnLine_HLT_HIon.log

which confuses bot

missirol · 2022-10-09T12:01:50Z

For AddOn tests the link to hlt_mc_HIon is wrong

For the record, this has happened before (#36408 (comment)). #36423 was an attempt to fix it, but it was not integrated (while cms-sw/cms-bot#1675 was..).

perrotta · 2022-10-09T18:06:19Z

There are DQM differences for JetMET in several workflows: not clear if and why this PR can have generated them...

fwyzard · 2022-10-09T18:27:08Z

I doubt this PR can cause any changes in physics or reconstruction quantities...

perrotta · 2022-10-09T21:40:30Z

please test

cmsbuild · 2022-10-10T04:02:16Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0130f6/28142/summary.html
COMMIT: 730ad74
CMSSW: CMSSW_12_6_X_2022-10-09-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39636/28142/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestGeneratorInterfaceEvtGenInterface_external_bplus had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0130f6/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3392309
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3392284
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2022-10-10T05:42:24Z

+1

The differences in the DQM comparisons have disappeared
The unit test error didn't show up in previous tests, and t is clearly unrelated

perrotta · 2022-10-10T05:43:26Z

merge

Add Service type in an exception message

1444453

cmsbuild added this to the CMSSW_12_6_X milestone Oct 5, 2022

cmsbuild added code-checks-pending core-pending orp-pending pending-signatures tests-pending labels Oct 5, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 5, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2022

fwyzard reviewed Oct 5, 2022

View reviewed changes

FWCore/ServiceRegistry/interface/ServiceRegistry.h Outdated Show resolved Hide resolved

Use demangled name in exception messages

730ad74

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Oct 5, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 5, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2022

cmsbuild removed the tests-started label Oct 6, 2022

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Oct 6, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 7, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 8, 2022

cmsbuild added tests-started and removed tests-approved labels Oct 9, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2022

cmsbuild merged commit 5f6ead8 into cms-sw:master Oct 10, 2022

makortel deleted the serviceRegistryExceptionMessage branch October 10, 2022 14:55

cmsbuild mentioned this pull request Oct 10, 2022

MTD geometry: update BTL description #39670

Merged

missirol mentioned this pull request Nov 8, 2022

Remove MVASelector tags for tracking in data GTs + re-snapshot frozen GT #40011

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Service type in an exception message from ServiceRegistry #39636

Add Service type in an exception message from ServiceRegistry #39636

makortel commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

makortel commented Oct 5, 2022

makortel commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

makortel commented Oct 5, 2022

cmsbuild commented Oct 6, 2022

cmsbuild commented Oct 6, 2022

rappoccio commented Oct 7, 2022

rappoccio commented Oct 7, 2022

cmsbuild commented Oct 8, 2022

smuzaffar commented Oct 9, 2022 •

edited

missirol commented Oct 9, 2022

perrotta commented Oct 9, 2022

fwyzard commented Oct 9, 2022

perrotta commented Oct 9, 2022

cmsbuild commented Oct 10, 2022

perrotta commented Oct 10, 2022

perrotta commented Oct 10, 2022

Add Service type in an exception message from ServiceRegistry #39636

Add Service type in an exception message from ServiceRegistry #39636

Conversation

makortel commented Oct 5, 2022

PR description:

PR validation:

cmsbuild commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

makortel commented Oct 5, 2022

makortel commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

cmsbuild commented Oct 5, 2022

makortel commented Oct 5, 2022

cmsbuild commented Oct 6, 2022

Unit Tests

RelVals-INPUT

AddOn Tests

Comparison Summary

cmsbuild commented Oct 6, 2022

rappoccio commented Oct 7, 2022

rappoccio commented Oct 7, 2022

cmsbuild commented Oct 8, 2022

Comparison Summary

smuzaffar commented Oct 9, 2022 • edited

missirol commented Oct 9, 2022

perrotta commented Oct 9, 2022

fwyzard commented Oct 9, 2022

perrotta commented Oct 9, 2022

cmsbuild commented Oct 10, 2022

Unit Tests

Comparison Summary

perrotta commented Oct 10, 2022

perrotta commented Oct 10, 2022

smuzaffar commented Oct 9, 2022 •

edited