Remove ME0 from HGCal custom (but not HGCalMuon)

[mark-grimes]

HGCalMuon and HGCalMuon4Eta have ME0 but HGCal does not. Previously they both used the same customisation and so HGCal (142xx) failed in step 2 because it couldn't find the ME0 hits. With this pull request the customisations are diverged.

The effective only change is that HGCal calls cust_2023Pixel() before applying the HGCal specifics. It previously called cust_2023Muon() instead. HGCalMuon and HGCalMuon4Eta still call cust_2023Muon().

The consequence is that HGCal no longer has these two lines in the customisation sequence:

process=customise_rpc(process)
process=customise_me0(process)

@ianna, is it correct to remove the customise_rpc call as well? I did it this way because it was easier to delegate to the cust_2023Pixel function.

After this change the 142xx tests run through step 2 and fail in step 3 with the same crash as all the others.

[cmsbuild]

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Remove ME0 from HGCal custom (but not HGCalMuon)

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

Fully tested but I'll wait for the go ahead from @ianna before merging. Ping @boudoul as well.

Tests 10000, 10200, 10400, 11200, 11400, 12000, 12800, 13000, 13600 and 14600 pass all steps.
Test 12600 fails in step 2 (as before) with:

#5  0x00002ab13a645b8a in HcalDDDRecConstants::getHCID(int, int, int, int, int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libGeometryHcalCommonData.so
#6  0x00002ab149808871 in HcalHitRelabeller::relabel(unsigned int) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#7  0x00002ab1498089cf in HcalHitRelabeller::process(std::vector<PCaloHit, std::allocator<PCaloHit> >&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#8  0x00002ab1497f2f29 in HcalDigitizer::accumulateCaloHits(edm::Handle<std::vector<PCaloHit, std::allocator<PCaloHit> > > const&, edm::Handle<std::vector<PCaloHit, std::allocator<PCaloHit> > > const&, int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#9  0x00002ab1497f3819 in HcalDigitizer::accumulate(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libSimCalorimetryHcalSimProducers.so
#10 0x00002ab14978c8bb in edm::MixingModule::accumulateEvent(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so
#11 0x00002ab14978c8e1 in edm::MixingModule::addSignals(edm::Event const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so
#12 0x00002ab14986d64b in edm::BMixingModule::produce(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libMixingBase.so

Tests 12200, 12400, 13800, 14000, 14200 and 14400 fail in step 3 (as before, except 14200 gets this far as well) with:

#5  0x00002b31683f5668 in ECAL2DPositionCalcWithDepthCorr::update(edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libRecoParticleFlowPFClusterProducer.so
#6  0x00002b31683a50c3 in PFClusterProducer::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/pluginRecoParticleFlowPFClusterProducerPlugins.so

I had a crash with 12200 in step 2 the first time I tested, then ran it again and it passed which is a little worrying. I'll look through to see if I can find any use of uninitialised memory. The crash was:

#5  0x00002afd94559e0f in ME0EtaPartitionSpecs::ME0EtaPartitionSpecs(GeomDetEnumerators::SubDetector, std::string const&, std::vector<float, std::allocator<float> > const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw-patch/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/libGeometryGEMGeometry.so
#6  0x00002afd94549fe1 in ME0GeometryBuilderFromDDD::buildGeometry(DDFilteredView&, MuonDDDConstants const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libGeometryGEMGeometryBuilder.so
#7  0x00002afd9454a57b in ME0GeometryBuilderFromDDD::build(DDCompactView const*, MuonDDDConstants const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libGeometryGEMGeometryBuilder.so
#8  0x00002afd9480da04 in ME0GeometryESModule::produce(MuonGeometryRecord const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/pluginME0GeometryESModule.so

[mark-grimes]

merge

We'll try this in the next IB along with #3967 to see how the build, and revert any problems later.

[ianna]

@mark-grimes - RPCs are part of all Phase 2 scenarios. It's only ME0 can be missing if there is no space for it. BTW, I'm not sure Extended pixel is part of HGCal scenarios yet - should it be included?