Shashlik DIGI-RECO #3967

shervin86 · 2014-05-22T14:58:00Z

Working version of the shashlik DIGI-RECO

Changes Geometry and SIM:

Fix geometry by Ianna: shashlik geometry in CaloGeometryBuilder
Fix geometry by Fedor: Shashlyk bug fix 3, including Pull Request: Shashlyk bug fix 3 #3957
assert in preshower geometry initialization removed
Fix SIM parameters for shashlik from Sasha:
- UseBirkLaw: True -> False (non linearity behaviour of the light yield w.r.t. energy loss)
- UseWeight : True -> False (weigth for light collection of different fibers depending on the energy deposit position)
- ReadOutType: 1 -> 0 (0 = 4 fibers combined, one readout)
- AttCorrection: True -> False

DIGI:

EKDetId with hashedIndex
EcalPhaseIIDigiProducer: removed preshower digitization, added Shashlik
- added Shashlik specific configurations and classes for electronics
- Noise fixed at 0.3 ADC (2 MeV)
- Digi are Zero Suppressed at 1 ADC count: for digi need unsuppressed digis around signal

RECO:

Uncalibrated recHits and calibrated recHits added
Particle Flow sequences added (check customization needed before)
Fixed clustering

VALIDATION:
Temporary removed some validations, still to be fixed (running without crashing)

…metry. Add it in configurations.

…using fixed (by define) crystal for EK conditions

…unts, 5 ADC threashold for shashlik

# The first commit's message is: temporarly removed simHit in digi validation # The 2nd commit message will be skipped: # fixup temporarly removed simHit in digi validation # The 3rd commit message will be skipped: # fixup temporarly removed simHit in digi validation

…th Shashlik Conflicts: RecoParticleFlow/PFClusterProducer/src/Navigators.cc add in hgcal navigators, update navigator base for 3D Conflicts: RecoParticleFlow/PFClusterProducer/src/Navigators.cc fixed particle flow shashlik rechit producer name

cmsbuild · 2014-05-22T15:03:13Z

A new Pull Request was created by @shervin86 for CMSSW_6_2_X_SLHC.

Shashlik DIGI-RECO

It involves the following packages:

AnalysisDataFormats/SUSYBSMObjects
CalibCalorimetry/EcalLaserCorrection
CalibCalorimetry/EcalTrivialCondModules
CondFormats/ESObjects
CondFormats/EcalObjects
Configuration/Geometry
DQM/EcalEndcapMonitorTasks
DQM/HcalMonitorTasks
DQMOffline/JetMET
DataFormats/EcalDetId
DataFormats/EcalDigi
DataFormats/EcalRecHit
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/EcalAlgo
Geometry/HGCalCommonData
Geometry/HGCalSimData
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaTools
RecoLocalCalo/Configuration
RecoLocalCalo/EcalRecProducers
RecoParticleFlow/PFClusterProducer
SLHCUpgradeSimulations/Configuration
SimCalorimetry/Configuration
SimCalorimetry/EcalSelectiveReadoutProducers
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimCalorimetry/EcalZeroSuppressionAlgos
SimCalorimetry/EcalZeroSuppressionProducers
SimG4CMS/Calo
SimGeneral/MixingModule
Validation/EcalDigis
Validation/EcalHits
Validation/EcalRecHits

The following packages do not have a category, yet:

Geometry/HGCalSimData

@apfeiffer1, @diguida, @StoyanStoynev, @danduggan, @civanch, @ianna, @mdhildreth, @monttj, @cmsbuild, @Dr15Jones, @rcastello, @deguio, @slava77, @ggovi, @vadler, @Degano, @ojeda, @rovere, @ktf, @thspeer, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @wmtan, @lgray, @nhanvtran, @argiro, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

mark-grimes · 2014-05-22T18:05:37Z

AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml

-   <class name="susybsm::HSCPCaloInfo" ClassVersion="11">
-    <version ClassVersion="11" checksum="1170741674"/>
+   <class name="susybsm::HSCPCaloInfo" ClassVersion="12">
+    <version ClassVersion="12" checksum="2407040083"/>


I get a compiler error from this, complaining that the checksum should be 1170741674 (i.e. the original). I'll revert it myself and carry on testing for now, then put in my own pull request if I need to.

Please patch it up and keep going, put the necessary commit somewhere where Shervin can tack it onto the PR. @shervin86

there is something strange with the checksums. if it compiles for me it does not for the others. any hint?

Da: Lindsey Gray
Inviato: giovedì 22 maggio 2014 20:08
A: cms-sw/cmssw
Rispondi a: cms-sw/cmssw
Cc: Shervin Nourbakhsh
Oggetto: Re: [cmssw] Shashlik DIGI-RECO (#3967)

In AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml:

@@ -20,8 +20,8 @@

Please patch it up and keep going, put the necessary commit somewhere where Shervin can tack it onto the PR. @shervin86 https://github.com/shervin86

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3967/files#r12964817.

I just finished the build and didn't get any complaints.

On Thu, May 22, 2014 at 1:13 PM, shervin86 notifications@github.com wrote:

In AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml:

@@ -20,8 +20,8 @@

there is something strange with the checksums. if it compiles for me it
does not for the others. any hint? Da: Lindsey Gray Inviato: giovedì 22
maggio 2014 20:08 A: cms-sw/cmssw Rispondi a: cms-sw/cmssw Cc: Shervin
Nourbakhsh Oggetto: Re: [cmssw] Shashlik DIGI-RECO (#3967 #3967)
In AnalysisDataFormats/SUSYBSMObjects/src/classes_def.xml:
@@ -20,8 +20,8 @@
- - + +
Please patch it up and keep going, put the necessary commit somewhere
where Shervin can tack it onto the PR. @shervin86 https://github.com/shervin86
https://github.com/shervin86 — Reply to this email directly or view it
on GitHubhttps://github.com//pull/3967/files#r12964817.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3967/files#r12965191
.

I wonder if this is a case of picking up something from the base release that will then crash the building of the next IB?

mark-grimes · 2014-05-22T19:00:41Z

I'm a little concerned about the differences I see and what others get. I'm going to try again in a fresh release area, but for the record this is what I get this time around. Note that this was on top of #3957 and #3960 which I merged this afternoon so aren't in the IB yet.

10000, 10200, 10400, 11200, 11400, 12000, 12400, 12800, 13000, 13600, 13800, 14000 and 14600 pass all steps.

12200, 14200 and 14400 crash in step 2 with:

#5  0x00002b2ae6ba559e in EcalPhaseIIDigiProducer::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimProducers.so
#6  0x00002b2ae694c76b in edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so

12600 crashes in step 2 with:

ShashlikGeometry::getGeometry-> inconsistent geometry structure 1009284208(32874->1006686810) inside: (EK iz -  fiber 0, RO 0, ix 210, iy 90)(1006686810->32874) given: (EK iz +  fiber 0, RO 0, ix 116, iy 112)(1008759920) ref (EK iz -  fiber 0, RO 0, ix 210, iy 90)
%MSG
cmsRun: /tmp/grimes/CMSSW_6_2_X_SLHC_2014-05-22-0200/src/SimCalorimetry/EcalSimAlgos/src/EcalHitResponse.cc:283: double EcalHitResponse::timeOfFlight(const DetId&) const: Assertion `0 != cellGeometry' failed.

andersonjacob · 2014-05-22T19:07:43Z

I have used:

CMSSW_6_2_X_SLHC_2014-05-22-0200 + #3957 #3960 #3964 #3967

everything compiled fine.

I ran the matrix and have this result

passing tests: 10000,10200,10400,11200,11400,12000,12400,12800,13000,13600,13800,14000,14600
failing tests:
12200 Step2-FAILED code 34304
12600 Step2-FAILED code 34304
14200 Step2-FAILED code 34304
14400 Step2-FAILED code 34304

12200,14200 and 14400 have this message

#5  0x00002b282ebe559e in EcalPhaseIIDigiProducer::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimProducers.so
#6  0x00002b282e98c76b in edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so

in 12600 the error is

%MSG-e HGCalGeom:  MixingModule:mix 22-May-2014 20:44:39 CEST Run: 1 Event: 1
ShashlikGeometry::getGeometry-> inconsistent geometry structure 1009284208(32874->1006686810) inside: (EK iz -  fiber 0, RO 0, ix 210, iy 90)(1006686810->32874) given: (EK iz +  fiber 0, RO 0, ix 116, iy 112)(1008759920) ref (EK iz -  fiber 0, RO 0, ix 210, iy 90)
%MSG
cmsRun: /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/src/SimCalorimetry/EcalSimAlgos/src/EcalHitResponse.cc:283: double EcalHitResponse::timeOfFlight(const DetId&) const: Assertion `0 != cellGeometry' failed.

It looks like the same thing as you have. I guess we can merge them then and see if the next IB breaks in some horrible fashion that we don't completely understand.

shervin86 · 2014-05-22T19:51:53Z

this seems one of the problem that Fedor's pull request should have solved. could you try without any other PR?

Da: andersonjacob
Inviato: giovedì 22 maggio 2014 21:07
A: cms-sw/cmssw
Rispondi a: cms-sw/cmssw
Cc: Shervin Nourbakhsh
Oggetto: Re: [cmssw] Shashlik DIGI-RECO (#3967)

I have used:

CMSSW_6_2_X_SLHC_2014-05-22-0200 + #3957 #3957 #3960 #3960 #3964 #3964 #3967 #3967

everything compiled fine.

I ran the matrix and have this result

passing tests: 10000,10200,10400,11200,11400,12000,12400,12800,13000,13600,13800,14000,14600
failing tests:
12200 Step2-FAILED code 34304
12600 Step2-FAILED code 34304
14200 Step2-FAILED code 34304
14400 Step2-FAILED code 34304

12200,14200 and 14400 have this message

#5 0x00002b282ebe559e in EcalPhaseIIDigiProducer::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/libSimCalorimetryEcalSimProducers.so
#6 0x00002b282e98c76b in edm::MixingModule::finalizeEvent(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/lib/slc5_amd64_gcc472/pluginSimGeneralMixingModulePlugins.so

in 12600 the error is

%MSG-e HGCalGeom: MixingModule:mix 22-May-2014 20:44:39 CEST Run: 1 Event: 1
ShashlikGeometry::getGeometry-> inconsistent geometry structure 1009284208(32874->1006686810) inside: (EK iz - fiber 0, RO 0, ix 210, iy 90)(1006686810->32874) given: (EK iz + fiber 0, RO 0, ix 116, iy 112)(1008759920) ref (EK iz - fiber 0, RO 0, ix 210, iy 90)
%MSG
cmsRun: /afs/cern.ch/work/a/andersj/upgrade/CMSSW_6_2_X_SLHC_2014-05-22-0200/src/SimCalorimetry/EcalSimAlgos/src/EcalHitResponse.cc:283: double EcalHitResponse::timeOfFlight(const DetId&) const: Assertion `0 != cellGeometry' failed.

It looks like the same thing as you have

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3967#issuecomment-43931021.

mark-grimes · 2014-05-22T23:40:04Z

merge

I still get the checksum compilation error but nobody else does. Let's try it in the next IB to see if it builds. I'll get a pull request ready to revert the checksum change in case it fails.

@shervin86, I tried on top of CMSSW_6_2_X_SLHC_2014-05-22-0200 with no other pull requests but still get the same (plus some other tests failing). Did you do a full checkdeps? Let's see how it is in tomorrow's IB.

Shashlik DIGI-RECO

mark-grimes · 2014-05-22T23:49:31Z

I've got #3975 ready in case the Integration Build has the same compilation error.

mark-grimes · 2014-05-23T07:30:42Z

Integration Build appears to have gone through fine. The failures in the tests are the same.

The HGCal (122xx,142xx and 144xx) customisations have the extended pixels in but the scenario does not, so I'd expect something to go wrong with those. I'm surprised it's in EcalPhaseIIDigiProducer though. I'll look it this and either change the customisations or add extended pixels into the scenarios.

The 12600 error is odd though. Could someone look into that?

shervin86 · 2014-05-23T08:29:34Z

I'll have a look in later this morning

Da: Mark Grimes
Inviato: venerdì 23 maggio 2014 09:31
A: cms-sw/cmssw
Rispondi a: cms-sw/cmssw
Cc: Shervin Nourbakhsh
Oggetto: Re: [cmssw] Shashlik DIGI-RECO (#3967)

Integration Build appears to have gone through fine. The failures in the tests are the same.

The HGCal (122xx,142xx and 144xx) customisations have the extended pixels in but the scenario does not, so I'd expect something to go wrong with those. I'm surprised it's in EcalPhaseIIDigiProducer though. I'll look it this and either change the customisations or add extended pixels into the scenarios.

The 12600 error is odd though. Could someone look into that?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3967#issuecomment-43979049.

shervin86 · 2014-05-23T14:40:59Z

After some fixes I continue to have this error for 12200:
#5 0x00002b7d98cfdc9e in SeedingLayerSetsBuilder::layers(edm::EventSetup const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libRecoTrackerTkSeedingLayers.so
#6 0x00002b7dcd68f58e in CombinedHitTripletGenerator::init(edm::ParameterSet const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/pluginRecoPixelVertexingPixelTripletsPlugins.so

davidlange6 · 2014-05-23T14:43:12Z

which you would indeed expect if there is a mis-match between the tracker geometry and customize function…

On May 23, 2014, at 4:41 PM, shervin86 notifications@github.com
wrote:

After some fixes I continue to have this error:
#5 0x00002b7d98cfdc9e in SeedingLayerSetsBuilder::layers(edm::EventSetup const&) const () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/libRecoTrackerTkSeedingLayers.so
#6 0x00002b7dcd68f58e in CombinedHitTripletGenerator::init(edm::ParameterSet const&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-05-18-0200/lib/slc5_amd64_gcc472/pluginRecoPixelVertexingPixelTripletsPlugins.so

—
Reply to this email directly or view it on GitHub.

mark-grimes · 2014-05-23T14:45:04Z

Try on the latest head. #3981 was merged a few hours ago which fixes the geometry-customise mismatch. Or tell me where your fixes are and I'll have a go.

shervin86 · 2014-05-23T14:59:31Z

The fixes I mentioned are in this PR #3990
I would wait for Jeremy Mans answer or need somebody to have a look at the second commit on the CaloTowerConstituentsMapBuilder

andersonjacob · 2014-05-23T15:18:26Z

Kevin Pedro is probably the one who would be best to look at it.

ianna and others added 29 commits May 22, 2014 13:42

Fix Shashlik reco geometry. Make it accessible as CaloSubDetector geo…

6d2f5e2

…metry. Add it in configurations.

preshower geometry patched

055b9d0

Geometry changes by Fedor

cb2f60a

Fixed bug caused by sensitive calibration fiber

8e3980e

changed path for ecalcontainer, shashlik in EcalCondObjectContainer, …

f4315cc

…using fixed (by define) crystal for EK conditions

EK laser correction from one LM of EE

51852fc

added EKDigiCollection, EK classes in EcalSimAlgos

62a366b

EcalDigi for Shashlik in EcalPhaseIIDigiProducer.cc

109d9ef

commented preshower in digi step

7751a10

shashlik electronic parameters configurable

33f9ff8

EK noise fixed to 2MeV, 0.3 adc

0185886

EK collections in FEVTDEBUG output

6174686

removed digis for invalid shashlik detIds

a8592d2

ZeroSuppression for ekDigis, threashold also in fixed value of ADC co…

728f569

…unts, 5 ADC threashold for shashlik

added EKrechit collection

43effbf

ecalRecHit producer fixed for shashlik

77e4356

merged with pf_shashlik from lindsey

2364d00

fixing clustering

fcfd911

EE rechit collection removed

0fe9e67

added ShashlikSimHits validation

c0525b1

working version of validation step with shashlik (not crashing)

e5a2cf0

update to test shashlik

deed099

temporarly removed ecalSelectiveReadoutValidation from sequence

a6aaf85

temporarly removed rechit validation

a17b7b3

removed checks for EE in DQM in upgrade, to be fixed

74c94d7

update SHCal customize put Shashlik clusters into PF workflow

0e811ee

fixed wrong packages in BuildFiles

8b02678

shervin86 added the alca-pending label May 22, 2014

shervin86 added db-pending labels May 22, 2014

andersonjacob mentioned this pull request May 22, 2014

Baseline needs for Shashlik/HGC to be in PF #3892

Closed

mark-grimes reviewed May 22, 2014
View reviewed changes

mark-grimes mentioned this pull request May 22, 2014

Remove ME0 from HGCal custom (but not HGCalMuon) #3964

Merged

cmsbuild added a commit that referenced this pull request May 22, 2014

Merge pull request #3967 from shervin86/pf_shashlik-rebase-v11

9a5393b

Shashlik DIGI-RECO

cmsbuild merged commit 9a5393b into cms-sw:CMSSW_6_2_X_SLHC May 22, 2014

mark-grimes mentioned this pull request May 22, 2014

Revert checksum in case IB fails #3975

Merged

shervin86 deleted the pf_shashlik-rebase-v11 branch November 22, 2014 11:20

mark-grimes mentioned this pull request Jun 10, 2015

Remove error messages about missing collections from 2017 validation sequence #9545

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shashlik DIGI-RECO #3967

Shashlik DIGI-RECO #3967

shervin86 commented May 22, 2014

cmsbuild commented May 22, 2014

mark-grimes May 22, 2014

lgray May 22, 2014

shervin86 May 22, 2014

andersonjacob May 22, 2014

andersonjacob May 22, 2014

mark-grimes commented May 22, 2014

andersonjacob commented May 22, 2014

shervin86 commented May 22, 2014

mark-grimes commented May 22, 2014

mark-grimes commented May 22, 2014

mark-grimes commented May 23, 2014

shervin86 commented May 23, 2014

shervin86 commented May 23, 2014

davidlange6 commented May 23, 2014

mark-grimes commented May 23, 2014

shervin86 commented May 23, 2014

andersonjacob commented May 23, 2014

Shashlik DIGI-RECO #3967

Shashlik DIGI-RECO #3967

Conversation

shervin86 commented May 22, 2014

cmsbuild commented May 22, 2014

mark-grimes May 22, 2014

Choose a reason for hiding this comment

lgray May 22, 2014

Choose a reason for hiding this comment

shervin86 May 22, 2014

Choose a reason for hiding this comment

andersonjacob May 22, 2014

Choose a reason for hiding this comment

andersonjacob May 22, 2014

Choose a reason for hiding this comment

mark-grimes commented May 22, 2014

andersonjacob commented May 22, 2014

shervin86 commented May 22, 2014

mark-grimes commented May 22, 2014

mark-grimes commented May 22, 2014

mark-grimes commented May 23, 2014

shervin86 commented May 23, 2014

shervin86 commented May 23, 2014

davidlange6 commented May 23, 2014

mark-grimes commented May 23, 2014

shervin86 commented May 23, 2014

andersonjacob commented May 23, 2014