PPS automatic workflows for timing calibration #39652

ChrisMisan · 2022-10-06T13:11:26Z

PR description:

This PR adds a set of configuration files for offline calibration workflow described in:
https://indico.cern.ch/event/1200233/contributions/5049293/attachments/2511413/4316826/PPS%20Timing%20Calibration%20talk.pdf s.11

and:

https://twiki.cern.ch/twiki/bin/viewauth/CMS/CTPPSTimeCalibration

PR validation:

Those files are intended only for the offline use, details on how to run them are included in: https://twiki.cern.ch/twiki/bin/viewauth/CMS/CTPPSTimeCalibration

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

no backport is needed

ChrisMisan · 2022-10-06T13:11:38Z

type ctpps, new-feature

cmsbuild · 2022-10-06T13:18:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32453

This PR adds an extra 20KB to repository

cmsbuild · 2022-10-06T13:18:39Z

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

CalibPPS/TimingCalibration (alca)
DQM/CTPPS (dqm)

@malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-10-06T17:48:57Z

CalibPPS/TimingCalibration/test/DiamondCalibrationHarvester_cfg.py

+process.load('Configuration.EventContent.EventContent_cff')
+process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
+from Configuration.AlCa.GlobalTag import GlobalTag
+process.GlobalTag = GlobalTag(process.GlobalTag, '124X_dataRun3_Prompt_frozen_v4', '')


I think this should be the autoCond map, not a fixed GT

tvami · 2022-10-06T17:49:24Z

CalibPPS/TimingCalibration/test/DiamondCalibrationHarvester_cfg.py

+################
+#geometry
+################
+process.load('Geometry.VeryForwardGeometry.geometryRPFromDD_2021_cfi') 


why isnt the geometry taken from DD4HEP?

tvami · 2022-10-06T17:49:41Z

CalibPPS/TimingCalibration/test/DiamondCalibrationHarvester_cfg.py

+process.load("DQMServices.Components.DQMEnvironment_cfi")
+process.dqmEnv.subSystemFolder = "CalibPPS"
+process.dqmSaver.convention = 'Offline'
+process.dqmSaver.workflow = "/CalibPPS/TimingCalibration/CMSSW_12_0_0_pre2"


CMSSW_12_0_0_pre2 ?

tvami · 2022-10-06T17:52:17Z

hi @ChrisMisan I made a few comments in one file, but they apply to all of the configs.

Should we also make these into a unit test? This wont be tested with the relval wf-s right?

ChrisMisan · 2022-10-06T19:46:10Z

hi @ChrisMisan I made a few comments in one file, but they apply to all of the configs.

Should we also make these into a unit test? This wont be tested with the relval wf-s right?

@tvami Thanks for the comments, I'll address them in the next commit. As for the unit test, I'm not sure. I can test if the script was executed successfully but it really doesn't give any useful information about the final outcome as it just submits jobs to crab. Do we have any mechanisms in place to test for crab jobs?

tvami · 2022-10-06T20:07:11Z

Hi Chris, no I was just thinking about running

DiamondSampicCalibrationWorker_cfg.py
DiamondSampicCalibrationHarvester_cfg.py

DiamondCalibrationHarvester_cfg.py
DiamondCalibrationWorker_cfg.py

directly locally in a unit test, we for sure dont need to do anything with CRAB here

ChrisMisan · 2022-10-06T20:24:05Z

Hi Chris, no I was just thinking about running
DiamondSampicCalibrationWorker_cfg.py
DiamondSampicCalibrationHarvester_cfg.py

DiamondCalibrationHarvester_cfg.py
DiamondCalibrationWorker_cfg.py
directly locally in a unit test, we for sure dont need to do anything with CRAB here

Ah, ok, then I think it can be arranged, I'll take a look and add it into next commit.

cmsbuild · 2022-10-07T18:32:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39652/32482

This PR adds an extra 16KB to repository

cmsbuild · 2022-10-07T18:33:03Z

Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

ChrisMisan · 2022-10-07T22:53:36Z

please test

cmsbuild · 2022-10-12T14:25:32Z

Pull request #39652 was updated. @malbouis, @yuanchao, @ChrisMisan, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

tvami · 2022-10-12T14:35:38Z

@cmsbuild , please test

ChrisMisan · 2022-10-12T17:49:57Z

error seems unrelated

cmsbuild · 2022-10-12T19:22:52Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28199/summary.html
COMMIT: c29f67f
CMSSW: CMSSW_12_6_X_2022-10-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39652/28199/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

140.56140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/20834.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/20834.75_TTbar_14TeV+2026D88_HLT75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HLT75e33+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/20896.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/20900.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/21034.999_TTbar_14TeV+2026D88PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-18a44d/23234.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3392309
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3392281
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-10-13T21:48:14Z

@cmsbuild , please test

cmsbuild · 2022-10-14T01:29:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a44d/28247/summary.html
COMMIT: c29f67f
CMSSW: CMSSW_12_6_X_2022-10-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39652/28247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3392309
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3392284
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 49 edm output root files, 49 DQM output files
TriggerResults: no differences found

tvami · 2022-10-14T01:36:34Z

+alca

tests, inc new unit test, pass

ChrisMisan · 2022-10-15T16:25:29Z

@perrotta PR was updated, is it ok for you to sign it like this?

perrotta · 2022-10-17T06:55:33Z

@perrotta PR was updated, is it ok for you to sign it like this?

Thank you @ChrisMisan for the updates that took care of the comments I had posted.
However, if is not up to me to sign this, rather @cms-sw/dqm-l2

emanueleusai · 2022-10-17T09:24:32Z

+1

cmsbuild · 2022-10-17T09:24:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-10-17T10:09:11Z

+1

cmsbuild added this to the CMSSW_12_6_X milestone Oct 6, 2022

cmsbuild added alca-pending code-checks-pending ctpps dqm-pending new-feature orp-pending pending-signatures tests-pending labels Oct 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2022

tvami reviewed Oct 6, 2022

View reviewed changes

ChrisMisan force-pushed the CMSSW_12_6_X branch from 795db6b to c9493ec Compare October 7, 2022 18:26

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 7, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 7, 2022

cmsbuild removed the tests-pending label Oct 7, 2022

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2022

cmsbuild added tests-rejected and removed tests-started labels Oct 12, 2022

cmsbuild added tests-started and removed tests-rejected labels Oct 13, 2022

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2022

cmsbuild added alca-approved and removed alca-pending labels Oct 14, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 17, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 17, 2022

cmsbuild merged commit 0df089b into cms-sw:master Oct 17, 2022

cmsbuild mentioned this pull request Oct 17, 2022

Remove use of legacy EDProducer from Framework tests #39745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PPS automatic workflows for timing calibration #39652

PPS automatic workflows for timing calibration #39652

ChrisMisan commented Oct 6, 2022

ChrisMisan commented Oct 6, 2022

cmsbuild commented Oct 6, 2022

cmsbuild commented Oct 6, 2022

tvami Oct 6, 2022

tvami Oct 6, 2022

tvami Oct 6, 2022

tvami commented Oct 6, 2022

ChrisMisan commented Oct 6, 2022 •

edited

tvami commented Oct 6, 2022

ChrisMisan commented Oct 6, 2022

cmsbuild commented Oct 7, 2022

cmsbuild commented Oct 7, 2022

ChrisMisan commented Oct 7, 2022

cmsbuild commented Oct 12, 2022

tvami commented Oct 12, 2022

ChrisMisan commented Oct 12, 2022

cmsbuild commented Oct 12, 2022

tvami commented Oct 13, 2022

cmsbuild commented Oct 14, 2022

tvami commented Oct 14, 2022

ChrisMisan commented Oct 15, 2022

perrotta commented Oct 17, 2022

emanueleusai commented Oct 17, 2022

cmsbuild commented Oct 17, 2022

perrotta commented Oct 17, 2022

PPS automatic workflows for timing calibration #39652

PPS automatic workflows for timing calibration #39652

Conversation

ChrisMisan commented Oct 6, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

ChrisMisan commented Oct 6, 2022

cmsbuild commented Oct 6, 2022

cmsbuild commented Oct 6, 2022

tvami Oct 6, 2022

Choose a reason for hiding this comment

tvami Oct 6, 2022

Choose a reason for hiding this comment

tvami Oct 6, 2022

Choose a reason for hiding this comment

tvami commented Oct 6, 2022

ChrisMisan commented Oct 6, 2022 • edited

tvami commented Oct 6, 2022

ChrisMisan commented Oct 6, 2022

cmsbuild commented Oct 7, 2022

cmsbuild commented Oct 7, 2022

ChrisMisan commented Oct 7, 2022

cmsbuild commented Oct 12, 2022

tvami commented Oct 12, 2022

ChrisMisan commented Oct 12, 2022

cmsbuild commented Oct 12, 2022

RelVals-INPUT

Comparison Summary

tvami commented Oct 13, 2022

cmsbuild commented Oct 14, 2022

Comparison Summary

tvami commented Oct 14, 2022

ChrisMisan commented Oct 15, 2022

perrotta commented Oct 17, 2022

emanueleusai commented Oct 17, 2022

cmsbuild commented Oct 17, 2022

perrotta commented Oct 17, 2022

ChrisMisan commented Oct 6, 2022 •

edited