[L1T] Fix mva ntuple variable

[epalencia]

PR description:

The ntuple was filling the track mva variable with -99 as a default until the mva variable was ready to be used. We have now replaced the -99 to the actual mva variable. This is a very minor change.

• Local PR: Fix mva ntuple variable cms-l1t-offline/cmssw#1046

PR validation:

This works correctly when running the ntuple. Basic formatting checks after the changes were made.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39730/32570

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc modified in PR(s): [L1T] Phase-2, Track MET update for FW sync #39725, [L1T] Phase-2, Create GTT to GT test vectors, and test vectors from the L1TrackSelectionProducer outputs #39422

[cmsbuild]

A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ae62a/28256/summary.html
COMMIT: 806a61d
CMSSW: CMSSW_12_6_X_2022-10-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39730/28256/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3392309
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3392281
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[srimanob]

Hi @epalencia
The PR looks obvious. Just to confirm, ->trkMVA1() always available, right?

[epalencia]

Hi @srimanob, I think so, @cgsavard could you please confirm?I

[cgsavard]

Yes, the variable trkMVA1() is always available. It is a part of the TTTrack class and has a default value even if the MVA is not run. @srimanob @epalencia

[srimanob]

+Upgrade

Thanks @cgsavard

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1