Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Phase-2 Tracker and HGCAL HLT config files #39733

Merged
merged 2 commits into from Oct 17, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Oct 14, 2022

PR description:

This is the same as the draft PR #39450 without updating the DQM.

This PR updates module and pset used in Phase-2 Tracker and HGCAL HLT. The update follows what defined in

To complete on PR test, and example of benefit from the new workflow, this PR also introduces a new workfow .76 which the DIGI and HLT:@relval2026 steps are running together instead of HLT:@fake. The new workflow will allow us to develop Phase2 HLT DQM and sequence to be used in future Phase-2 production.

Note that,

PR validation:

Run test with the following workflows:

  • 20834.75: To make sure that Phase-2 HLT is still running properly.
  • 20834.76: To show that DIGI and HLT:@relval2026 can run together.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

None.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39733/32576

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @AdrianoDee, @bbilin, @cmsbuild, @missirol, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @silviodonato, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 20834.76
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39733/32577

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0ab3/28260/summary.html
COMMIT: e947b31
CMSSW: CMSSW_12_6_X_2022-10-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39733/28260/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c0ab3/20834.76_TTbar_14TeV+2026D88_HLTwDIGI75e33+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0c0ab3/2500.601_mc126X+TTBarMINIAOD12.6+NANO_mc12.6+HRV_NANO_mc

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • Reco comparison had 7 failed jobs
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3391158
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3391133
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 201 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

This PR fixes the configuration and psets used by Phase-2 HLT step. The new workflow is added, to run both DIGI and HLT together.

@missirol
Copy link
Contributor

+hlt

It's not specific to the new wf, but this warning should either be investigated, or demoted to a LogDebug:

%MSG-w L1TrackJetEmulationProducer:   L1TrackJetEmulationProducer:l1tTrackJetsEmulation
 14-Oct-2022 16:53:55 CEST  Run: 1 Event: 1
L1TrkPtrs Not Assigned!

FYI: @cms-sw/l1-l2

@missirol
Copy link
Contributor

Kind ping to @cms-sw/pdmv-l2 for the review of this PR.

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants