Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use estimated PbPb beam conditions for 2022 HI MC instead of pp beam conditions #39761

Closed

Conversation

mandrenguyen
Copy link
Contributor

PR description:

Update the vertex smearing in 2022 HI MC RelVal workflows to use estimated PbPb beam conditions instead of defaulting to pp ones.
Complement to #39758 which updates the GT with reco beamspot that is compatible with this vertex smearing.
The relevant auto conditions are updated to point to this latest GT.

PR validation:

Needs to be tested with #39758

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Will need a 12_5_X backport.

@tvami

@mandrenguyen
Copy link
Contributor Author

hold
Oops @tvami I just realized this is a superset of your PR. Do you want to just grab the edits to relval_steps.py and we can do this in a single PR and close this one? Sorry for the noise.

@cmsbuild cmsbuild added the hold label Oct 18, 2022
@tvami
Copy link
Contributor

tvami commented Oct 18, 2022

hi Matt, sure, I can do that! thanks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39761/32622

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @sunilUIET, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @tocheng, @trtomei, @mmusich, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

Will be implemented in #39758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants