allow SoA Pixel RecHits monitoring to run in Phase-2 workflows

[mmusich]

PR description:

Title says it all, minimal set of modifications to be able to run the SoA pixel rechits monitoring in the phase-2 workflows.
The code - even if used for Phase-2 - still resides in DQM/SiPixelPhase1Heterogeneous (which is a misnomer). We plan further clean-up of the naming and extending to the tracks and vertices by using class templates once the dust settles on #38761.

PR validation:

Tested on lxplus-gpu by running runTheMatrix.py --what upgrade -l 20834.507 -t 4 -j 8 and checked that plots are filled correctly:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cc:
@AdrianoDee @sroychow

[mmusich]

type trk, new-feature

[mmusich]

test parameters:

• enable_tests = gpu
• workflows_gpu = 21034.507, 20834.507
• relvals_opt= -w upgrade

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39771/32640

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiPixelPhase1Heterogeneous/plugins/SiPixelPhase1MonitorRecHitsSoA.cc modified in PR(s): Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/SiPixelPhase1Heterogeneous (dqm)
• DQMOffline/Configuration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @threus, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: RelVals-GPU
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eddd9b/28366/summary.html
COMMIT: 33c0db3
CMSSW: CMSSW_12_6_X_2022-10-19-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39771/28366/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-GPU

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391127
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

judging from log it looks like the bot commands #39771 (comment) are not the correct ones to test the workflow of interest.
@smuzaffar @cms-sw/upgrade-l2 can you help in setting it correctly? Thanks

[AdrianoDee]

I think one would need to add:

• relvals_opt_gpu = -w upgrade

? Guessing from the bot instructions here. I haven't actually tested it yet.

[mmusich]

test parameters:

• enable_tests = gpu
• workflows_gpu = 21034.507, 20834.507
• relvals_opt= -w upgrade
• relvals_opt_gpu = -w upgrade

[mmusich]

please test

• let's try again

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eddd9b/28390/summary.html
COMMIT: 33c0db3
CMSSW: CMSSW_12_6_X_2022-10-19-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39771/28390/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391124
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /pool/condor/dir_226364/jenkins/workspace/compare-root-files-short-matrix/data/PR-eddd9b/20834.507_TTbar_14TeV+2026D88_Patatrack_PixelOnlyTripletsGPU_Validation+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
• /pool/condor/dir_226364/jenkins/workspace/compare-root-files-short-matrix/data/PR-eddd9b/21034.507_TTbar_14TeV+2026D88PU_Patatrack_PixelOnlyTripletsGPU_Validation+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 128585
• DQMHistoTests: Total failures: 24
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 128561
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 38494.252 KiB( 5 files compared)
• DQMHistoSizes: changed ( 20834.507 ): 23610.955 KiB SiPixelHeterogeneous/PixelRecHitsCompareGPUvsCPU
• DQMHistoSizes: changed ( 20834.507 ): 7441.648 KiB SiPixelHeterogeneous/PixelRecHitsSoACPU
• DQMHistoSizes: changed ( 20834.507 ): 7441.648 KiB SiPixelHeterogeneous/PixelRecHitsSoAGPU
• Checked 20 log files, 16 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• differences in GPU as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1