Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cond boost aarch64 71x #3978

Merged
merged 2 commits into from May 23, 2014
Merged

Cond boost aarch64 71x #3978

merged 2 commits into from May 23, 2014

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented May 23, 2014

Backport from CMSSW_7_2_X. CMSSW_7_1_X is potentially a better release for doing x86_64 vs aarch64 comparison.

David Abdurachmanov added 2 commits May 23, 2014 09:43
condformats_serialization_generate.py: support for aarch64
3f95459 
LLVM/Clang on AArch64 will report that most AST nodes are not
definition, which is not true. The following modifies script to
check definition based on location information directly (file, line,
 and column).

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Convert missed two is_definition() calls to is_definition_by_loc()
0015035 
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_7_1_X.

Cond boost aarch64 71x

It involves the following packages:

CondFormats/Serialization

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1

On Fri, May 23, 2014 at 9:47 AM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @davidlt https://github.com/davidltfor CMSSW_7_1_X.

Cond boost aarch64 71x

It involves the following packages:

CondFormats/Serialization

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @deganohttps://github.com/degano,
@nclopezo https://github.com/nclopezo can you please review it and
eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo, @ktf https://github.com/ktfyou are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3978#issuecomment-43980338
.

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

This is the equivalent of #3948 in 72X. That one has been already merged in 72X and passes the tests. @davidlt needs this to be integrated to continue with his work. I will bypass the tests.

nclopezo added a commit that referenced this pull request May 23, 2014
@nclopezo
Merge pull request #3978 from davidlt/cond-boost-aarch64-71x
70b9f85 
CondFormats/Serialization -- Cond boost aarch64 71x
@nclopezo nclopezo merged commit 70b9f85 into cms-sw:CMSSW_7_1_X May 23, 2014
@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3978/1607/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3978/1607/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed tests-pending
Projects
None yet
Milestone
CMSSW_7_1_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @apfeiffer1 @nclopezo