PPS pixel improvement of error debugging

[fabferro]

PR description:

This PR is intended to improve the information used for error debugging of PPS pixel detector.
Two DQM plots are added to show the error reported during the data unpacking process.
A slight change in the data unpacker is implemented as well to send out more information in case of errors.

PR validation:

Private validation on Run3 data

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport foreseen.

@grzanka

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39787/32654

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

• DQM/CTPPS (dqm)
• EventFilter/CTPPSRawToDigi (reconstruction)

@micsucmed, @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @forthommel, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376dd/28399/summary.html
COMMIT: 45d2a53
CMSSW: CMSSW_12_6_X_2022-10-20-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39787/28399/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391133
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.25399999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 2.662 KiB CTPPS/TrackingPixel
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabferro]

It seems the RelVal-INPUT tests failed due to TIMEOUT.
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376dd/28399/runTheMatrixINPUT-results/matrixTestsINPUT.log
Maybe they should be rerun.

[mandrenguyen]

please test
Let's retry

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6376dd/28419/summary.html
COMMIT: 45d2a53
CMSSW: CMSSW_12_6_X_2022-10-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39787/28419/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391130
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.25399999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 2.662 KiB CTPPS/TrackingPixel
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1